Remove unused fields from the view [#635336]

The 'view_php' field will never be used. It existed as a field before displays were a concept. It should be removed, no harm will come of it.

The' is_cacheable' field is not in use and I am not sure if it will be removed. It was originally a hold over for the 'query' caching, but query caching never got implemented. It's possible that we will implement query caching, but we may do it differently. With plugins, though, there is more UI choice, so marking an overall 'is_cacheable' field seems unnecessary.

Comment	File	Size	Author
#4	635336-remove_fields.patch	6.15 KB	dawehner
#4
#1	views-635336-removed_fields.patch	7.25 KB	dawehner
#1

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

dawehner

German

CreditAttribution: dawehner commented 3 December 2009 at 23:21

Status:

Active

» Needs review

File	Size
views-635336-removed_fields.patch	7.25 KB

Here the patch comes.

Comment #2

merlinofchaos CreditAttribution: merlinofchaos commented 4 December 2009 at 01:39

Ok, this is going to be kind of annoying.

We're not supposed to actually modify views_schema_1() -- note that the very first update in the 6.x series loads views_schema_1() and creates it. So if we modify it, then someone updating from 5.x is going to end up going through an invalid path.

We already have an issue about that, in fact, but nothing's actually been done with it because it hasn't gotten high enough on my TODO list to actually do. So we're probably going to need to address that either before or while we address this. I'm not sure offhand what that issue nid is, but you can duplicate the issue by upgrading a drupal 5 site directly to a very recent version of Views.

Comment #3

dawehner

German

CreditAttribution: dawehner commented 9 February 2010 at 06:32

Status:

Needs review

» Needs work

Comment #4

dawehner

German

CreditAttribution: dawehner commented 27 May 2010 at 11:03

Status:

Needs work

» Needs review

File	Size
635336-remove_fields.patch	6.15 KB

Comment #5

merlinofchaos CreditAttribution: merlinofchaos commented 12 October 2010 at 23:20

Version:	6.x-3.x-dev	» 7.x-3.x-dev
Status:	Needs review	» Patch (to be ported)

Committed to 6.x branches.

Comment #6

dawehner

German

CreditAttribution: dawehner commented 16 October 2010 at 08:42

Status:

Patch (to be ported)

» Fixed

and fixed.

Comment #7

30 October 2010 at 08:50

Status:

Fixed

» Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Comment #8

calefilm CreditAttribution: calefilm commented 19 January 2012 at 16:54

Trying to fix my empty text dilemma after upgrading (see: http://drupal.org/node/1330148 ) I went back down to 6.14 and now get this warning:

user warning: Unknown column 'view_php' in 'field list' query: UPDATE views_view SET name = 'rmp_promo_reviews_per_employer', description = 'employer promo reviews', tag = 'employer promo reviews', view_php = '', base_table = 'node', is_cacheable = 0 WHERE vid = 354 in /Users/Cale/Sites/acquia-drupal/sites/all/modules/views/includes/view.inc on line 1722.

I can't get rid of it. I'm getting the same type of message when I save other views.

Comment #9

merlinofchaos CreditAttribution: merlinofchaos commented 19 January 2012 at 16:59

You need to clear caches to ensure the schema cache is rebuilt, I think.

Comment #10

calefilm CreditAttribution: calefilm commented 19 January 2012 at 17:23

I tried doing that. I think the problem was upgrading to 6.x-3.x-dev from 2.16 and then back down to 2.12. I upgraded my system every time but that must have confused things.

I will restore my system back to yesterday when I had 2.16 -- the only problem is I lose my empty text output when I overwrite my field in views.

Comment #11

calefilm CreditAttribution: calefilm commented 19 January 2012 at 17:34

Okay. Restored back to 2.16 and error disappears. Now I just need to figure out how to get the empty text output working again..

Comment #12

kentr CreditAttribution: kentr commented 6 December 2012 at 20:01

Trying to fix my empty text dilemma after upgrading (see: http://drupal.org/node/1330148 ) I went back down to 6.14 and now get this warning:
user warning: Unknown column 'view_php' in 'field list' query: UPDATE views_view SET name = 'rmp_promo_reviews_per_employer', description = 'employer promo reviews', tag = 'employer promo reviews', view_php = '', base_table = 'node', is_cacheable = 0 WHERE vid = 354 in /Users/Cale/Sites/acquia-drupal/sites/all/modules/views/includes/view.inc on line 1722.

You need to clear caches to ensure the schema cache is rebuilt, I think.

I've had success with putting the schema reset into the update function.

Example:

/**
 * Remove the view_php and is_cacheable field
 */
function views_update_6010() {
  $ret = array();

  db_drop_field($ret, 'views_view', 'view_php');
  db_drop_field($ret, 'views_view', 'is_cacheable');

  $schema = drupal_get_schema('views_view', TRUE);

  if (!empty($schema)) {
    $ret[] = array(
    'success' => TRUE,
    'query' => "Schema successfully reset for {views_view}."
    );
  }
  else {
    $ret[] = array(
        'success' => FALSE,
        'query' => "Schema not reset for {views_view}."
    );
  }

  return $ret;
}

In any event, running this code drupal_get_schema('views_view', TRUE); eliminates the 'view_php' error for me.