Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Found this module very useful for my projects and used it today the first time. As it was very small I's like to provide a German translation very soon. Before I provide any translation I'm mostly doing translatable string reviews...
Therefore I've done a full code review as the module wasn't that big... and fixed all code style issues, translatable string bugs and fixed SQL code style bugs plus a hook_help bug and so on... this patch touches many lines, but this is often only a missing blank and some things that make code more speedy and more specific (hook_preprocess_page and hook_form_FORM_ID_alter) as we know them and there is no need to fire on all available forms and preprocess hooks.
Code wise it should all be ok, I will do a test tomorrow on my DEV site.
| Comment | File | Size | Author |
|---|---|---|---|
| #7 | taxonomy_title_code_style_review-D6.patch | 4.64 KB | hass |
| #3 | taxonomy_title_review4.patch | 8.06 KB | hass |
| #2 | taxonomy_title_review3.patch | 8.08 KB | hass |
| #1 | taxonomy_title_review2.patch | 8.13 KB | hass |
| taxonomy_title_review.patch | 6.81 KB | hass |
Comments
Comment #1
hass CreditAttribution: hass commentedFixed a missing bracket.
Comment #2
hass CreditAttribution: hass commentedLooks like there is no need to check_plain the title. Removed the check_plain.
Comment #3
hass CreditAttribution: hass commentedNew patch. This one also fixes the bug that the title field is shown on the term delete page.
Comment #4
jenlampton@hass, thanks for all your work on this, I look forward to receiving your translation :-)
Committed to dev branch, new release shortly.
Jen
Comment #5
hass CreditAttribution: hass commentedIt looks like my fixes are not in 1.2
Comment #6
hass CreditAttribution: hass commentedComment #7
hass CreditAttribution: hass commentedNew patch attached. Please give me some time to update the translation file after the commit and before the next release.
http://drupal.org/coding-standards
http://drupal.org/project/coder
Comment #8
jenlamptonOk, committed the new patch, but may issue a new release for two other critical issues.
Comment #9
hass CreditAttribution: hass commentedWhat else is broken?
Comment #10
hass CreditAttribution: hass commented