Field revision data messed up when user has no 'edit' access on the field [#636834]

Pointed by plach in #629252-8: field_attach_form() should make available all field translations on submit:
When user has no 'edit access' for a field edits a node and creates a new revision, the field revision data is not properly created.

Attached patch is test that demonstrates the bug (should fail).

Comment	File	Size	Author
#3	field_form_fix_access.patch	17.04 KB	yched
#3
#1	field_form_fix_access.patch	16.99 KB	yched
#1
	field_form_fix_access_FAIL.patch	6.05 KB	yched

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

yched CreditAttribution: yched commented 19 November 2009 at 01:07

File	Size
field_form_fix_access.patch	16.99 KB

And that patch is test + fix (should pass).
Includes the field values as '#type' => 'value' elements in the form.

Comment #2

sun

German

Karlsruhe

CreditAttribution: sun commented 19 November 2009 at 10:35

Status:

Needs review

» Reviewed & tested by the community

Awesome.

+++ modules/simpletest/tests/field_test.module	19 Nov 2009 01:01:54 -0000
@@ -49,6 +49,15 @@ function field_test_menu() {
+function field_test_field_access($op, $field, $obj_type, $object, $account) {
+  if ($field['field_name'] == "field_no_{$op}_access") {
+    return FALSE;
+  }
+  return TRUE;
+}

So this is 90% of CCK field permissions in a core test module? Yay!? X-D

This review is powered by Dreditor.