clean up theme.css - miscellaneous cruft [#644160]

Comment #1

andrewmacpherson CreditAttribution: andrewmacpherson commented 26 November 2009 at 20:16

Version:	6.x-2.x-dev	» 6.x-2.0-beta2
Status:	Active	» Needs review

I'll refer to theme.css line numbers from from beta2

Log in or register to post comments

Comment #2

andrewmacpherson CreditAttribution: andrewmacpherson commented 26 November 2009 at 20:17

line 154 refers to sidebar-inner, which has gone:
/* Target a specific sidebar, inner or sidebar-inner. */

change to:
/* Target a specific sidebar. */

Log in or register to post comments

Comment #3

andrewmacpherson CreditAttribution: andrewmacpherson commented 26 November 2009 at 20:22

line 195 says "remove display:block..."

Remove implies there's something to delete; a better wording would be:
/* Over-ride display:block if you want the site name inline with the logo. */

Log in or register to post comments

Comment #4

andrewmacpherson CreditAttribution: andrewmacpherson commented 26 November 2009 at 20:57

line 451: What is .tags {} used for? I can't find the class in the HTML. The name suggests taxonomy, but it doesn't appear in the node taxonomy output.

Log in or register to post comments

Comment #5

andrewmacpherson CreditAttribution: andrewmacpherson commented 26 November 2009 at 21:17

lines 479-482 and 484-487:

.article ul.links selectors are repeated, only need one set.

Log in or register to post comments

Comment #6

andrewmacpherson CreditAttribution: andrewmacpherson commented 26 November 2009 at 21:27

line 511-513:

.first and .last classes for ul.links ?

These don't seem to be produced any more. Could we have them back, please? Perhaps another theme setting...

Log in or register to post comments

Comment #7

andrewmacpherson CreditAttribution: andrewmacpherson commented 26 November 2009 at 21:35

line 496 refers to
.article h3.vocab-name {}

However it would be a h2 element on standalone node/* pages. Perhaps it should be generalized to:
.article .vocab-name {}

starter.css (line 55) just uses this form.

Log in or register to post comments

Comment #8

andrewmacpherson CreditAttribution: andrewmacpherson commented 26 November 2009 at 21:43

line 497-499:

replace ul.terms with ul.vocab-list

Log in or register to post comments

Comment #9

Jeff Burnz CreditAttribution: Jeff Burnz commented 27 November 2009 at 00:11

Cheers, I've nailed everything so far and committed it so its in DEV.

I cant remember when I last used .tag, gawd, I think that was way back when...

Adding back in first and last just for node & comment links, hmm, not even sure how to do that, but if you enable .first and .last for Menu items in the theme settings these apply to the links lists.