Hi,

Module does not have any entry in permission table, I think should be at least one entry for allow view report (admin/reports/browscap), just because there is no way to delegate this option to other roles.

Comments

I agree, I need this one too.

...subscribing

Status:Active» Needs review
StatusFileSize
new2.8 KB

Patch provided.

Status:Needs review» Needs work

Looks mostly OK to me. However, given that the configuring can change an important function I suggest "administer browscap" instead of just "configure browscap."

What do you think?

Fine for me ;) Do you want me to re-roll a patch ?

Please do, yes.

Version:6.x-1.1» 6.x-1.x-dev
Status:Needs work» Needs review
StatusFileSize
new2.8 KB

New patch, with "administer browscap", done on the latest 6.x-1.x-dev.

#6 seems to work fine. Thanx ;)

Title:view report permission Add permission to view reports
Version:6.x-1.x-dev» 7.x-1.x-dev
Assigned:Unassigned» Devin Carlson
Issue tags:-granular permissions+Needs backport to 6.x
StatusFileSize
new2.47 KB

Moving to Browscap 7.x and then backporting.

The attached patch adds the permissions outlined in #6 to Browscap 7.x.

Version:7.x-1.x-dev» 6.x-1.x-dev
Status:Needs review» Needs work

Committed to 7.x-1.x.

Moving back to 6.x and marking as "needs work" to test the last patch for 6.x and ensure that it uses the same permission names as the 7.x patch.

Status:Needs work» Patch (to be ported)

Status:Patch (to be ported)» Needs review
StatusFileSize
new2.39 KB

Backport of #8.

Status:Needs review» Fixed

Committed to 6.x-1.x.

Thanx Devin! One less patch to keep around and having to re-apply with each installation.

PS: ...welcome as a new co-maintainer of Browscap btw ;)

Status:Fixed» Closed (fixed)
Issue tags:-Needs backport to 6.x

Automatically closed -- issue fixed for 2 weeks with no activity.