Node types lost during exported if module key not features, node [#654334]

When feature generates implementation of hook_node_info(), all the returned items have 'features' as their 'module'. For instance:

function _my_feature_node_info() {
  $items = array(
    'mytype' => array(
      'name' => t('My Type'),
      'module' => 'features',  //features as the module for the mytype node type
      'description' => t('My type description'),
      'has_title' => '1',
      'title_label' => t('Title'),
      'has_body' => '1',
      'body_label' => t('Body'),
      'min_word_count' => '0',
      'help' => '',
    ),
  );
  return $items;
}

Wouldn't it be better to use the exported feature/module name here ? Like this

function _my_feature_node_info() {
  $items = array(
    'mytype' => array(
      'name' => t('My Type'),
      'module' => 'my_feature', //my_feature as the module for the mytype node type
      'description' => t('My type description'),
      'has_title' => '1',
      'title_label' => t('Title'),
      'has_body' => '1',
      'body_label' => t('Body'),
      'min_word_count' => '0',
      'help' => '',
    ),
  );
  return $items;
}

This will allow the use hook_insert, hook_view, etc. when adding custom behaviors to an exported feature.

Comment	File	Size	Author
#8	654334-node-types-lost-custom-module-name-8.patch	571 bytes	erikwebb
#8
#6	654334_module_key.patch	739 bytes	hefox
#6
#3	654334_module_key.patch	738 bytes	hefox
#3

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

yhahn CreditAttribution: yhahn commented 21 December 2009 at 17:31

Status:

Active

» Fixed

As I've written here http://drupal.org/node/636402#comment-2396256 there are some reasons why we don't write the default node hooks for you.

If you'd like to override the module name for your feature and write your own hooks, however, this commit should let you do so.

http://drupal.org/cvs?commit=304998

Comment #2

4 January 2010 at 17:40

Status:

Fixed

» Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Comment #3

hefox CreditAttribution: hefox commented 4 November 2010 at 00:16

Status:

Closed (fixed)

» Active

File	Size
654334_module_key.patch	738 bytes

So I sorta finally got around to testing this, and it doesn't work on features-update without further manual intervention, as features drops the node type if it sees the module key isn't 'node' or 'features'.

Patch adds in a || isset map type (early check sees if isset and NOT module, so this check results in isset AND module defines the type).

Comment #4

hefox CreditAttribution: hefox commented 4 November 2010 at 00:17

Status:

Active

» Needs review

Comment #5

hefox CreditAttribution: hefox commented 4 November 2010 at 00:20

Title:

Use feature name as 'module' for exported node types

» Node types lost during exported if module key not features, node

Updating title to reflect current situation.

Comment #6

hefox CreditAttribution: hefox commented 4 November 2010 at 00:35

File	Size
654334_module_key.patch	739 bytes

Screw first patch
Last update today, I swear

Comment #7

hefox CreditAttribution: hefox commented 9 August 2011 at 08:12

To test.

1) Export a feature with a node type
2) Edit the hook_node_info in mymodule.features.inc and change 'features' for key 'module' to a non-existant module (ie. 'blahblah')
3) Features up the feature (drush fu -y mymodule).