This bug is easy to see if you use contextual links (for example to configure a block and move it from the left to right sidebar), or via straight up editing of a node.

When you submit the form, the overlay closes, and the parent window that you see underneath does not reflect the changes you made. Only if you reload the page manually do you see the changes.

The attached patch fixes it - note that all we have to do is remove some code! Discussed with @ksenzee and we both agreed that whatever benefit that code had in avoiding unnecessary redirects (I can't even find any at the moment?) is almost certainly overshadowed by this bug, so let's just remove it.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

David_Rothstein’s picture

Title: Changes made by submitting a form in the overlay are not reflected in the parent window » Changes made by submitting a form in the overlay are not reflected when the window automatically closes

Should clarify this... this patch only addresses the case where the overlay closes automatically on form submission. It does not address the case where you edit some stuff in the overlay, submit some forms which do not cause the overlay to automatically close, and then close the overlay manually. That one is a trickier bug which I will file as a separate issue a bit later.

David_Rothstein’s picture

ksenzee’s picture

Status: Needs review » Reviewed & tested by the community

This is a very straightforward change that I probably should have made before the initial commit.

webchick’s picture

Status: Reviewed & tested by the community » Fixed

Nice. I always love less buggy code that also results in less code. ;)

Committed to HEAD!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.