Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Compare:
/**
* Add a table to the query, without ensuring the path.
*
* This function will test to ensure that the path back to the primary
* table is valid and exists; if you do not wish for this testing to
* occur, use $query->queue_table() instead.
*
* @param $table
...
*/
function queue_table($table, $relationship = NULL, $join = NULL, $alias = NULL) {
with
/**
* Add a table to the query, ensuring the path exists.
*
* This function will test to ensure that the path back to the primary
* table is valid and exists; if you do not wish for this testing to
* occur, use $query->queue_table() instead.
*
* @param $table
...
*/
function add_table($table, $relationship = NULL, $join = NULL, $alias = NULL) {
It seems like the second paragraph was copy pasted. queue_table() does not call ensure_path(). I'd roll a patch but I'm not sure what to replace that paragraph with.
This appears to affect 7.x, 6.x-2.x and 6.x-3.x.
Comment | File | Size | Author |
---|---|---|---|
#3 | 657578-63x_comment_0.patch | 1001 bytes | iamjon |
Comments
Comment #1
dawehnerUpdate version
Comment #2
esmerel CreditAttribution: esmerel commentedComment #3
iamjon CreditAttribution: iamjon commentedPatch attached.
Changed it to:
Add a table to the query without ensuring the path. If you require that this testing
occur use $query->add_table() instead.
Comment #4
dawehnerLooks fine
Comment #5
esmerel CreditAttribution: esmerel commentedUnassigning from myself since I didn't do the work, and dereine has already reviewed it :)
Comment #6
merlinofchaos CreditAttribution: merlinofchaos commentedTechnically with doxygen we should only have one sentence on the first line, as that is the 'summary' you'll get when listing methods. Otherwise it's fine.
Comment #7
merlinofchaos CreditAttribution: merlinofchaos commentedI updated the text and committed to all 3 branches.