http://drupal.org/node/623976

Hesitant to report this because I know you tested the patch. I tend to think it is me now. However, for me it still returns 0 on no preference and hits on no smoking.

CommentFileSizeAuthor
#2 phpjpg.jpg115.86 KBweblance
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

willvincent’s picture

You applied the patch to the beta2 version, and still are not receiving results as expected?

Have you cleared your caches?

When you run a No Preference search, what is the last digit in the url? Should be a 2 for no preference, a 1 for smoking, and a 0 for non-smoking..

If the patch applied correctly, line # 343 of hotel_booking.module should be:

  if ($smoking < 2) {
weblance’s picture

FileSize
115.86 KB

I am running beta 2.

I clear cache, ran cron, forced update.

Patch appears correct (see jpg)

Url http://bookangeles.com/room_search/2009-12-31_1_1_0_2

willvincent’s picture

That looks correct.

I don't believe the code to display the room image(s) is included in beta2, so I assume you've altered the code at some point, perhaps that's broken something

willvincent’s picture

Status: Active » Closed (fixed)
weblance’s picture

I took my time in replying to your response because I was convinced I did something to create this bug as you suggested. Since I didn't alter any code I figured I must have some configuration that produced the error. Moreover, I am shocked to hear that images in search results are not part of the module. That is positively the strangest thing I have has happen in Drupal. I did not change a thing in the code so what in gods name is going on here?

Since I only know enough to annoy and get in trouble, I will hire a developer to look into this to figure it out and keep you updated. It might prove useful to someone down the road.

weblance’s picture

After uninstalling the module, updating, deleting all nodes, reinstalling, clearing cache, I still return no result with no preference option for search results.

If anyone else has experienced this, please let me know I am not alone.

danny1997’s picture

I have 3 rooms, 2 non-smoking and 1 smoking. Before I applied the patch http://drupal.org/node/623976, the result of no-preference is 0. After the patch, the result is 3.

So it works correctly now.

danny1997’s picture

Jeff,

I did some tests on you site http://bookangeles.com. I found out some strange things too.

Normally after the search, the date and preference fields should be cleaned up, that means they will return to the default values (date field -> blank, preference -> non-smoking). But on your site, the 2 fields kept my input values after the search. It shouldn't be!

If you did not alter the codes, maybe it's due to other modules you've installed. Try to do tests in another website with just the minimun modules installed.

Good luck!

weblance’s picture

Well, I have disabled every module except what is needed to run hotel booking and still am not able to get it to work.

I wonder if the patch is applying correct. That is to say, I wonder if I am applying it correctly. I done the patch 2 times now. Hmm, I will try again..

danny1997’s picture

Can you do tests in a new drupal site? I mean install a new one, not use the current site.

I've got some bad and surprising experences in doing what you are doing now and it seems many modules can't be disabled completely.

Apply the patch manually. It's not complicated by chanign 3 to 2!

weblance’s picture

This resolved itself in the latest dev version