When I first tried this module, I was very hesitant to hit the big red X because that is understood to mean Delete and I had no interest in deleting anything. I did realize it was for unselecting after hovering over it, but a different icon would be much better.

An empty check box might do the trick or maybe this should simply be words. Perhaps the best option would be to have the top item be "- None -" as is seen in CCK and other modules with lists like this. It is probably the most universal solution to when creating lists like this.

CommentFileSizeAuthor
#2 storm_dashboard_unselect_icon.patch556 bytesjurgenhaas
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

jurgenhaas’s picture

Status: Active » Needs review

You're absolutely right, I never liked that red cross myself and just haven't had time to find a better solution. The attached patch is using the ui_menu.png from the Storm icon set which is probably much better and still follows the general theme.

Your suggestion to use a '- none -' item has been implemented at the very beginning of this module and it turned out as a big space waster. Only 3 levels down in the dashboard you end up with 8 lists, if organizations are not collapsed there are even 14 select lists. If each of them has a '-none-' item at the beginning, almost a third of the space is wasted. That's why we replaced it with an icon.

Please let me know what you think about the new icon.

jurgenhaas’s picture

Sorry, patch was missing.

flickerfly’s picture

Status: Needs review » Reviewed & tested by the community

It is definitely an improvement, but the icon looks like something is selected so it suggests it leads to a selection rather than unselection. Still, it is better and I'd suggest implementing it as it will be easier to get used to.

(@jurgenhaas, Thanks for the ping for review.)

jurgenhaas’s picture

Status: Reviewed & tested by the community » Fixed

Thanks @flickerfly

Mark_Watson27’s picture

Hello,

The ui_menu icon was going to be used in context menu shortcuts, but that stalled in development.
Just thought I'd let you know.

Cheers
Mark

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.