Great module! I'm using a genesis subtheme, which is comprised of subfolders within the subtheme root folder. However, theme_editor is only seeing subtheme directory root level files only. Consequently I can only edit a small subset of my theme files.

For example:

Theme editor only sees:

customTheme.info
css
images
layout.css
logo.png
template.php
templates
theme_editor_backup

My customTheme folder:

|-- customTheme.info
|-- css
|   |-- README.txt
|   |-- _all-lite-tidy.css
|   |-- _all-lite.css
|   |-- blocks.css
|   |-- comments.css
|   |-- ie
|   |   `-- ie-example.css
|   |-- nodes.css
|   |-- page.css
|   `-- style.css
|-- images
|   |-- hover_bg.gif
|   |-- menu-bullet-active.png
|   |-- menu-bullet.png
|   |-- menu-sprite.gif
|   |-- menu-sprite.png
|   `-- screenshot_lite.png
|-- layout.css
|-- logo.png
|-- template.php
|-- templates
|   |-- README.txt
|   |-- block
|   |   `-- block.tpl.php
|   |-- box
|   |   `-- box.tpl.php
|   |-- comment
|   |   |-- comment-wrapper.tpl.php
|   |   `-- comment.tpl.php
|   |-- node
|   |   `-- node.tpl.php
|   |-- page
|   |   `-- page.tpl.php
|   `-- user
|       `-- user-picture.tpl.php
`-- theme_editor_backup
CommentFileSizeAuthor
#12 theme_editor.patch8.11 KBakv66
#9 110413-13-22.patch37.31 KBd0ublej0
#2 663914.patch3.23 KBarcaneadam
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

twooten’s picture

twooten CreditAttribution: twooten commented

I'm having the same issue, any luck getting it resolved?

arcaneadam’s picture

arcaneadam CreditAttribution: arcaneadam commented
Status: Active » Postponed
FileSize
663914.patch3.23 KB

Yes, this a known issue. Part of the reasoning behind this was that some themes have subthemes in subfolders of the parent theme and this would pollute the files list. At the time it seemed like a logical choice to me, but I realize that there are probably alot more themes that have files nested in sub folders them there are themes that that have sub themes.

If made a patch that will fix this and I may release this in a minor version release but I am working on a new major release where this will be irrelevant anyway don't hold your breath though cause it's a ways off..

arcaneadam’s picture

arcaneadam CreditAttribution: arcaneadam commented
Status: Postponed » Closed (fixed)
Marko B’s picture

Marko B CreditAttribution: Marko B commented

Well think you could just make a part where you check if in subdirectory there is .info file, if there is ignore it, that way you skip subthemes.

WebNewCastle’s picture

WebNewCastle CreditAttribution: WebNewCastle commented

I would vote for a change to include files in sub-folders as higher priority than tackling the various scenarios related to sub-themes.

To be upfront, I'm probably saying partly because I'm not a huge fan of nor personally see high value in sub-themes in general. But also, from a numbers perspective, I think there are far more themes with sub-folders than sub-themes. And it makes more sense to me to support something more clear cut like a main theme than the numerous possible constructs of a sub-theme that doesn't stand alone.

It's pretty common for JS files to be in JS folder, CSS files in a CSS folder, etc. to help with the organization of some of the more robust themes. In my case, some intricate custom themes have a dozen or more TPL files, etc., and the organization into sub-folders can be useful to avoid clutter.

So, I just wanted to add my vote for this part if it's not too much work to have the module file scan beyond the first level. Thanks!

arcaneadam’s picture

arcaneadam CreditAttribution: arcaneadam commented

I like #4's idea. I will look at a way to implement that and then go for it.

Marko B’s picture

Marko B CreditAttribution: Marko B commented

Glad i could help :-)

TechNikh’s picture

TechNikh CreditAttribution: TechNikh commented
Status: Closed (fixed) » Active

I am very much interested to see this feature. Can I know the status of this?

d0ublej0’s picture

d0ublej0 CreditAttribution: d0ublej0 commented
FileSize
110413-13-22.patch37.31 KB

Unfortunately the attached patch doesn't fix the problem for me, because although files stored in subfolders are listed they aren't editable; so I've created an additional quick patch which fixs this issue. The patch also contains a better formatting of the source code; that's why the patch contains a lot of changes ;)

hal9000_jr’s picture

hal9000_jr CreditAttribution: hal9000_jr commented

@dOublej0

Thanks for the patch. What version of theme_editor did you use this against? The whole patch is rejected when run against a fresh install of theme_editor-6.x-1.4 as well as an install that had the original patch in #2 applied.

Thanks.

Marko B’s picture

Marko B CreditAttribution: Marko B commented

From the Date in file it looks like its patch for 1.3 file version. Would be nice that there is at least DEV version of this module for online editing with this patches. (for d6)

akv66’s picture

akv66 CreditAttribution: akv66 commented
FileSize
theme_editor.patch8.11 KB

Hi, find a temporary patch to see and be able to edit the files in the subfolders. I know it is not perfect, but it is a mix of the patch #2 and another one found for D7 :)