Hi,

CKeditor hide "Show summary in full view" checkbox (using a display:none css property) which prevents having a teaser different from the full body.

Thanks

Laurent

CommentFileSizeAuthor
#8 ckeditor-665108.patch1.13 KBmephir
#1 ckeditor-665108.patch783 bytesmephir
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

mephir’s picture

mephir CreditAttribution: mephir commented
Status: Active » Needs review
FileSize
ckeditor-665108.patch783 bytes
wwalc’s picture

wwalc CreditAttribution: wwalc commented
Status: Needs review » Needs work

Works, but I think we could add also

teaser.checkboxContainer.hide();

in Drupal.ckeditorOff when teaser exists, but is empty ( !(data.length>1) )?

mephir’s picture

mephir CreditAttribution: mephir commented
Status: Needs work » Fixed

changes commited to cvs

Agence Web CoherActio’s picture

Agence Web CoherActio CreditAttribution: Agence Web CoherActio commented

Works perfectly
Thanks
Laurent

Agence Web CoherActio’s picture

Agence Web CoherActio CreditAttribution: Agence Web CoherActio commented
Status: Fixed » Active

Hi again,

I'm re-opening the issue because the fix brought a side-effect.

I can now see the checkbox. If I untick it and save, this works fine (teaser not displayed with full view).

However when I edit again the node, the checkbox comes ticked. So when I save, my initial set up is erased (this means that I have to remember to untick everytime).

Any way to fix this?

Many thanks

Laurent

Agence Web CoherActio’s picture

Agence Web CoherActio CreditAttribution: Agence Web CoherActio commented

Any idea where the issue can come from?
Thanks
Laurent

wwalc’s picture

wwalc CreditAttribution: wwalc commented
Assigned: Unassigned » mephir
mephir’s picture

mephir CreditAttribution: mephir commented
Status: Active » Needs review
FileSize
ckeditor-665108.patch1.13 KB

Patch attached.

Agence Web CoherActio’s picture

Agence Web CoherActio CreditAttribution: Agence Web CoherActio commented
Status: Needs review » Reviewed & tested by the community

Tested.
Works perfectly
Many thanks
Laurent

mephir’s picture

mephir CreditAttribution: mephir commented
Status: Reviewed & tested by the community » Fixed

Changes commited to cvs

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

mErilainen’s picture

mErilainen CreditAttribution: mErilainen commented

Could somebody describe what is this patch supposed to do? I can hide the checkbox with CSS, using 1.0 version of the module. Or was that the fix?

Anyway, I think it should be an option in the module to hide the button. It's not always useful and will just confuse most of the users.

mephir’s picture

mephir CreditAttribution: mephir commented

Patch was released before merging changes into CVS repository and release 1.0 version, so now you don't need patch.

pagach’s picture

pagach CreditAttribution: pagach commented

The #8 patch did not work for me, so i changed

var ch_checked = teaser.checkbox.attr('checked');

into

var ch_checked = teaser.checkbox[0].checked;

and

teaser.checkbox.attr('checked', 'false');

into

teaser.checkbox[0].checked=ch_checked;