Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
First, thanks for this great module.
Just wanted to know if/when you would implement the SUM aggregation ?
Comment | File | Size | Author |
---|---|---|---|
#20 | views_groupby_669070-20-6.x-1.x-rc2-p0.patch | 2.45 KB | patcon |
#18 | views_groupby_669070-6.x-1.x-dev.patch | 2.69 KB | arithmetric |
#10 | views_groupby_669070-6.x-1.x-rc2.patch | 2.61 KB | jm.federico |
#14 | views_groupby_669070_2-6.x-1.x-rc2.patch | 2.51 KB | jm.federico |
#9 | views_groupby_669070.patch | 2.75 KB | rsevero |
Comments
Comment #1
cerup CreditAttribution: cerup commentedI''d also like to know.
Comment #2
irakli CreditAttribution: irakli commentedLast I checked, sum aggregation needs a patch to Views module. I will have to check again and will post response/patch. Will try to do it sooner rather than later.
Thanks.
Comment #3
SanDiego CreditAttribution: SanDiego commentedSUM, AVERAGE, etc. type of functions would be a great addition to functionality. Looking forward to receiving the patch. Thanks...
Comment #4
redben CreditAttribution: redben commentedRe-changing title
Comment #5
Skispcs CreditAttribution: Skispcs commentedI would also like the SUM and other features.
Comment #6
chrisirhc CreditAttribution: chrisirhc commentedHere's a diff of my changes in order to make it work with MIN (tested), MAX, SUM, AVG. (This is based on the 6.x-rc2 release and it is not the standard patch)
It's cleaner than the patch given in: #702176: Rewriting GROUP BY part of the SQL and cheating to integrate Sum and Avg functions
Could someone please test this out for me?
Comment #7
dafederWorking for me so far, thanks!
Comment #8
servantleader CreditAttribution: servantleader commentedWorks great for me. I was using the MIN function in my use case. No errors or problems.
Comment #9
rsevero CreditAttribution: rsevero commentedI've just adapted the patch from comment #6 so it can be applied in current code and tested it. It's working fine.
Please consider integrating it into code.
Comment #10
jm.federico CreditAttribution: jm.federico commentedPatch againts RC2 (reversed, DO NOT USE) check #14
Comment #11
frjo CreditAttribution: frjo commentedI have been testing patch #9 on a local dev site and it works well. I'm using the "sum" function. Have not encountered any problems, error messages in the log etc.
Comment #12
NaX CreditAttribution: NaX commentedI am using #9 without any problems. Based on the feedback here I think this is ready to be committed.
Please note that it looks like the patch on #10 is inverted, like a rollback/remove feature patch.
Comment #13
bfellows CreditAttribution: bfellows commentedThis is a great addition to the v-groupby module. I was able to successfully patch the module manually; I am a linux idiot and couldn't get it to take via the command line patch util.
Comment #14
jm.federico CreditAttribution: jm.federico commentedRerolling againts RC2. patch in #10 is reversed.
@NaX: thanks
Comment #15
mattiasj CreditAttribution: mattiasj commentedThanks alot for this patch, truly helped out and works like a charm.
Comment #16
lord_of_freaks CreditAttribution: lord_of_freaks commentedSuscribing
Comment #17
mjumbewu CreditAttribution: mjumbewu commentedSubscribing
Comment #18
arithmetric CreditAttribution: arithmetric commentedAttached is an updated patch for the latest dev version (6.x-1.x) from the patch on #14 (which is for 6.x-1.0-rc2).
Comment #19
patcon CreditAttribution: patcon commentedHoly crap. This is awesome. Is anyone taking donations for this?! It totally just saved my keister.
Comment #20
patcon CreditAttribution: patcon commentedOh hey, here's a patch that will work with drush_make (-p0 instead of -p1, which is needed to strip off the module directory).
Comment #21
patcon CreditAttribution: patcon commentedWow. This, along with views_customfields, makes views so fracking powerful. I'm blown away by how well this works. Just, wow.
Comment #22
obrienmd CreditAttribution: obrienmd commentedWhen trying to patch latest 6.x-1.x-dev with #18 or #20, I get:
Comment #23
patcon CreditAttribution: patcon commented#20 is for the stable rc, since I needed a non-moving target for my drush_make files. But there's no dev build more recent than what #18 was rolled against anyhow. trying patching with the dev one from within the actual module's folder with -p0, and it should work :)
~/path/to/dir/views_groupby $ patch -p0 < patchie-patch-patch.patch
Comment #24
obrienmd CreditAttribution: obrienmd commentedLooks like that worked, thanks :)
Comment #25
Shadlington CreditAttribution: Shadlington commentedJust chipping in to say that #20 worked great for me. This should really get committed...
Comment #26
obrienmd CreditAttribution: obrienmd commentedAgreed, this needs to be committed ASAP. I makes the module much more widely useful.
Comment #27
patcon CreditAttribution: patcon commentedI totally agree. This patch by @chrisirhc is really clean, and it would be great to see #20 committed. Works great for me.
Comment #28
justafish#20 also worked well against rc2 for me. Any reason we can't commit this?
Comment #29
obrienmd CreditAttribution: obrienmd commentedUpdate: irakli has let me know s/he will be reviewing this soon!
Comment #30
patcon CreditAttribution: patcon commentedAwesome!
Comment #31
jm.federico CreditAttribution: jm.federico commentedAbsolutely fantastic! Thanks!
Comment #32
mattiasj CreditAttribution: mattiasj commentedthanks!
Comment #33
bobju CreditAttribution: bobju commentedThanks! :-)
Comment #34
irakli CreditAttribution: irakli commentedComitted: http://drupal.org/cvs?commit=484634
Comment #36
hartogsmith CreditAttribution: hartogsmith commentedmassive, massive thank for the original module and this patch.
Comment #37
joya CreditAttribution: joya commentedSubscribing
Comment #38
hendrohwibowo CreditAttribution: hendrohwibowo commented#20 and #23 works like a charm.
Sorry if this issue is already closed. I just try drupal for one month (mar 2012) and i have to express my thank yo since i am relieved by the patch.
Thank you again