This issue is for tracking the task of porting Search by Page to Drupal 7.

I expect this will take some time and effort, but I do plan to do it soon...

I might wait until these issues have been fixed first:
(definitely) #662282: Support for multilingual sites
(maybe) #492878: Multiple search types

CommentFileSizeAuthor
#10 674070-fix-for-780154.patch6.26 KBjhodgdon
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

jhodgdon’s picture

Status update:
- The above issues have been fixed (at least provisionally)
- I have a first version of Search by Page for Drupal 7, except the Attachments sub-module. I'll be committing it shortly and making a development version of 7.x Search by Page available. Then I'll continue by porting the Attachments sub-module to Drupal 7.

jhodgdon’s picture

Version: 6.x-1.x-dev » 7.x-1.x-dev

Update:
I just committed a version of the Attachments sub-module, which appears to work. I still need to rewrite the tests for Attachments and get them to pass, before I'll be confident that it works completely. But it's at least able to search file attachments!

jhodgdon’s picture

One note: If you want to test out the Attachments sub-module, you will need the Drupal 7 version of Search Files API. I ported that to Drupal 7 and attached it to this issue on that project:
http://drupal.org/node/712002#comment-2589112

You can download the zip file there.

jhodgdon’s picture

Status: Active » Needs review

Update: The Drupal 7 port in the repository is now completely working, with tests. The version you can download on the project home page should be updated within the next 12-24 hours.

jhodgdon’s picture

Update: I have just updated the Drupal 7 version to have the same functionality as 6.x-1.9. Also added a feature to let you choose the number of search results per page (which cannot easily be added to Drupal 6 version, because the core Search module is not flexible in that way in Drupal 6). I also realized that the Drupal 6-7 upgrade functions for this module would not have worked, so fixed those.

I'll commit these changes to the 7.x development branch (HEAD in cvs) shortly (as soon as I finish running the tests and verify that everything is OK).

jhodgdon’s picture

Update: There have been some changes to Drupal 7 that required some changes to the SBP module family. Sigh. It's fun trying to chase a moving target. This one: SBP family of modules would not install due to this change:
http://drupal.org/update/modules/6/7#install-schema

This is now fixed in CVS; should be downloadable within a day or so.

jhodgdon’s picture

Status: Needs review » Needs work

I noticed a couple of days ago that the D7 version of Search by Page is failing tests again... so I will need to update it again.

jhodgdon’s picture

Status: Needs work » Needs review

Things are working again in the D7 version. For the moment, until D7 itself changes again...

jhodgdon’s picture

Status: Needs review » Needs work

Just a note that D7 changed again -- the default markup for search results changed. So this module needs to catch up again. There are also several issues I've fixed in the D6 version of SBP whose fixes need to be ported to the D7 version (you can look at the issue list to see them).

jhodgdon’s picture

FileSize
6.26 KB

Here's a patch for the Drupal 7 version, in anticipation of
#780154: There is no listing API for field API
being committed to D7.

I haven't committed these changes yet.

jhodgdon’s picture

Status: Needs work » Needs review

These changes have been committed now, along with some additional changes to keep up with Drupal 7. The module is working again... HEAD to HEAD updates are NOT being maintained, but Drupal 6 to Drupal 7 updates are.

Status: Needs review » Needs work

The last submitted patch, 674070-fix-for-780154.patch, failed testing.

jhodgdon’s picture

Status: Needs work » Needs review
jhodgdon’s picture

Once again, I found that the D7 version of Search by Page wasn't working, due to changes in Drupal 7. This time, I probably cannot compain too much, because the changes were mostly in the core Search module, which I'm actually (in practice, if not in name) the main maintainer of... Anyway, I've made another update to the D7 version of Search by Page, and all the tests are passing again (and the module appears to work correctly). This time at least the changes were just a couple of lines.

jhodgdon’s picture

See http://drupal.org/node/864518#comment-3345686 for a note on the status of the D7 port, especially in regards to PostgreSQL compatibility.

jhodgdon’s picture

Status: Needs review » Fixed

7.x-1.0 has been released!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.