Let's make it easy for Drush users to download it!

CommentFileSizeAuthor
#1 674454-ckeditor-drush-D6.patch1.63 KBDave Reid
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Dave Reid’s picture

Status: Active » Needs review
FileSize
1.63 KB
wwalc’s picture

Great, thanks for adding a patch. I didn't review it yet but looks good.
Just a note for me to not forget about it - the svn URL should be changed, http://svn.fckeditor.net/CKEditor/releases/stable will be valid since tomorrow or something like that (CKEditor 3.1 is coming! ;))

wwalc’s picture

Status: Needs review » Reviewed & tested by the community
mephir’s picture

Thanks

mephir’s picture

Status: Reviewed & tested by the community » Fixed
jcisio’s picture

Status: Fixed » Active

This patch uses the default path sites/all/libraries/ckeditor instead of the one defined by the module sites/all/modules/ckeditor/ckeditor.

mephir’s picture

Status: Active » Fixed

The path of ckeditor isn't important, because ckeditor can find editor in libraries directory. Libraries directory is pretty good, because if you are using drush update, it delete ckeditor module directory and create new one, if we decided to download editor to ckeditor module directory, you would be forced to download editor again, after all ckeditor module updates.

jcisio’s picture

Thanks for the explanation ;) Very helpful. I didn't know that before, so I created a symlink to libraries/ckeditor, but it's ok now.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Robin van Emden’s picture

Category: feature » bug
Status: Closed (fixed) » Active

The "ckeditor download" command should be replaced by "ckeditor-download" due to changes in drush:

Notice: "ckeditor download" must be renamed to "ckeditor-download" in[error]
order to work with this version of drush. If you are the maintainer
for the module that defines this command, please rename it
immediately. If you are a user of this command, you may enable
spaces in commands for a while by setting "allow-spaces-in-commands"
in your drush configuration file. See example.drushrc.php.

Otherwise, great include!

mephir’s picture

Status: Active » Fixed

Changes commited to CVS.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

fuzzy76’s picture