This module needs documentation to see exactly what each action does and when the triggers are pulled.

CommentFileSizeAuthor
#5 uc_discount-688966.patch14.98 KBjantoine
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

dave_______1’s picture

Status: Fixed » Active

Hi Agilware,

I'd like to see some documentation too.
I understand the options are in here /admin/store/ca/add but not sure how to use them?!

I'm trying to discount for bulk orders on some of my products e.g. customer buys 1 they pay 74.99, but if they buy 10 they pay 599.99.
This needs to show in the basket, the cart and the checkout.

My site is here http://satandcable.com and by the time this is read I will have gave up and used the product kit I think :(

Tried the uc_discount, this module and the product kit to get this working but I'm not having any luck.

If anyone could help I'll buy you a beer when you're in Liverpool next!

Thanks.
Dave.

sp3boy’s picture

I heartily agree - I've just installed the module and there are now four triggers under Discount but no clue - not even a README.txt - to suggest what circumstances they fire under.

All I want to achieve is that if the customer selects a line quantity between 3 and 9 they get charged less per item and for 10+ they get charged even less. That sounds like a job for the "Calculate line item discounts" trigger but if I select that the available conditions have nothing to do with line quantity and the only preset action offered is to display a message.

I don't want to spend more hours trying to make the module do something that it's not currently capable of :(

Royce-1’s picture

I agree, I think its a shame when great modules leave users with no idea how to use them unless they want to read ALL the code. Its a waste.

charlie-s’s picture

Well, the best ways for non-programmers to contribute back to the community are to

1) Submit bugs and details the steps to recreate them
2) Submit / amend documentation

I'll be using this module in just a few minutes and will try to post w/e I come up with back here. I encourage anyone else to do the same and perhaps the combined dialogue will result in a page of documentation on these triggers.

jantoine’s picture

Status: Active » Needs review
FileSize
14.98 KB

Here is a patch with a first shot at documentation. It doesn't cover everything, but it definitely better than what we have (nothing).

Cheers,

Antoine

Scott M. Sanders’s picture

Regarding #2, "Calculate line item discounts," does this work?

ptoly’s picture

#4 = That's a catch 22 if I ever heard of one!

You want non programmers to submit documentation on an undocumented module that they don't know how to read the code to figure out...

I know (from 20 years of doing this) that many brilliant programmers hate to document. However the fact remains that, unless you document, and document well, your brilliance will not shine forth...

#5 Thanks! Only thing is I can't figure out where to apply this patch. It says index/help/about.html and I don't see any such path.... ?

joachim’s picture

Is the patch in #5 for use with the advanced_help module?

While I think that can only be a good thing, I think it's also quicker and easier to write documentation in a handbook page on drupal.org. That way, people can quickly contribute to it without having to go through the bottleneck of a maintainer.

deggertsen’s picture

The patch in #5 is great. Should definitely be committed. Thanks for that.

However I also agree with joachim that there should be a documentation page as well for those who haven't yet installed the module. I usually like to figure out how it works before I install a module so that is a must for people like me.

goose2000’s picture

Does the module actually contain discounts methods that can be used right away? Which kinds? Needs some more explanation.

smscotten’s picture

Patch #5 is exactly what's needed. I'm all for adding that information elsewhere, but anyone wanting to look at documentation beyond what's in a README.txt (so kindly provided by the patch) should be willing to install the Advanced Help module.

Whether to put docs in handbook pages or Advanced Help is a higher-level issue. There should be a way to keep module documentation in sync between modules and handbook pages but I'm not ready to tackle that question today. The topic for this thread is very well addressed by the patch. I'd be happy to see it committed. I bet it will lead to more constructive participation on this module because people won't give up on the module before figuring out what to do.

joachim’s picture

Status: Needs review » Fixed

Point taken. This patch needs to be in.

I've added a regular hook_help with the summary from the README and a pointer to install AH, and removed the spurious full stops in the AH topic titles.

#688966 by AntoineSolutions, joachim: Added documentation: README, core help, Advanced Help.

Anyone want to start a documentation page?

joachim’s picture

Status: Active » Fixed

@dave_______1 -- please don't edit ancient comments on issues. It makes it very hard to understand what is being said and what has been added.

jwilson3’s picture

example03.html's functionality has also been questioned here: #950918: Coupon code discount does not work

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

TribalMan’s picture

I am still seeing no documentation. Has this patch been committed?

TribalMan’s picture

right! I was using uc_discounts!