Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Currently says 'User terms'. This could make it look like it's somehow part of site T&Cs!
I think it would be better as 'Vocabularies', same as on the node forms.
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | user_terms_view_fieldset.patch | 4.29 KB | Nigel Cunningham |
| #4 | user_terms_view_fieldset.patch | 4.29 KB | Nigel Cunningham |
Comments
Comment #1
Todd Nienkerk CreditAttribution: Todd Nienkerk commentedA "vocabulary" has a distinct meaning in Drupal, as does a "term." The label "Vocabularies" would make me think I'm supposed to assign entire vocabularies to a user — not necessarily their component terms.
I agree that "User terms" could, in some cases, be confused for "Terms and conditions," but I think "vocabularies" confuses the point even more. How about we let the site admin change the label in the module's settings interface?
Comment #2
joachim CreditAttribution: joachim commented'Vocabularies' is what it says on node edit forms, so there is a consistency there. It's a fieldset for picking stuff from vocabularies.
I'm not sure how you might think that on the user edit account you assign vocabs, especially as you're not being show vocabs but terms. That said, users who see this form will probably not know the inner workings and setup of taxonomy module.
We could say that site builders are going to use this for such a variety of things that they need control over how to present it to the user -- but exactly the same is true of taxonomy on nodes, and there it says 'Vocabularies' too. Site builders have to use string overrides or hook_form_alter to change that label on nodes.
I'm loath to chuck in a setting for this for several reasons: I generally to think too many modules chuck in too many settings to fine-tune things like this; we'd still have to provide a default, so it doesn't make the problem go away; and I see this module as providing what core does with taxonomy for nodes, but on users instead, hence extra tweaks beyond that seems like too much. Not to mention that then it spoils the upgrade path to FieldAPI on D7.
Comment #3
greg.harveyIMHO the label of the fieldset as viewed by users on account pages should be the vocab name - that way the label is editable, but it's nothing to do with User Terms - it's inherited from Taxonomy settings.
Comment #4
Nigel CunninghamI wanted to merge the content into the Profile fieldset, and created the attached patch.
It lets you specify which fieldset to use, and what title to use if you're not reusing an existing fieldset.
Comment #5
Nigel CunninghamSmall correction - while testing I changed some instances of 'User Terms' so I could easily check things were working. I missed reverting a couple of those changes.
Comment #6
joachim CreditAttribution: joachim commentedSorry, but moving things into given fieldsets is the province of a custom hook_form_alter, not an admin setting. We certainly don't want a UI in which you're expected to type a formAPI key.
Comment #7
Nigel CunninghamThanks for the reply.
Fair enough.
So (just to make sure I'm perfectly clear) even if I rerolled it so you didn't have to type a formAPI key, but instead selected it from a dropdown (including an item for having it separate as is the case now), you'd still want to see that be a separate module, rather than a patch to this one?
I suppose in that case it could be generalised/extended to let you rearrange and regroup all of the fields :) Hmmm - wonder if something like that exists already.
Comment #8
joachim CreditAttribution: joachim commentedI think this is best handled either with custom code, or alternatively, done with http://drupal.org/project/formdefaults (which I've just found out about).
Otherwise, this module would just get overloaded with tiny settings.
Comment #9
Nigel CunninghamOooh. Going off the description, that does look like a good module. I'll give it a go. Thanks!
Comment #10
titaniumbones CreditAttribution: titaniumbones commentedPerhaps I should start a new thread, but am I right that it's also impossible to move the User Terms to the bottom of the page, or assign a weight like the other fields get? Right now they're sort of incongruously at the top of one of my pages.
Thanks!