I've been seeing breadcrumbs breaking due to the system being unable to figure out what the active menus are on dynamic paths.

IMO we should try a bit harder to determine the active menu.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

bdragon’s picture

Status: Active » Needs review
FileSize
1.47 KB

chx pointed out in IRC that we didn't need the query builder in the first place.

Also, I'm more sure of myself this time around. Let's see what the tests say.

carlos8f’s picture

Issue tags: +Needs tests

Can you point out the pages that are broken? Let's write some tests.

chx’s picture

bdragon’s picture

Sorry about that, had a power outage for something like an hour right as I was finishing up typing this, and had to shut down my network completely because I didn't have the battery power to keep it up for that long.
--

Anything that has a wildcard in the path that doesn't have a seperate menu_link for the exact path being requested was resetting the breadcrumb to "Home" due to not being able to find the active menu.

For example, listing terms in a vocabulary. (admin/structure/taxonomy/1 after creating a vocabulary)
Before patch:

Home

After patch:

Home » Administer » Structure » Taxonomy
bdragon’s picture

Assigned: Unassigned » bdragon

Writing tests now.

Nick Lewis’s picture

Status: Needs review » Closed (duplicate)

This is actually a dup of #576290: Breadcrumbs don't work for dynamic paths & local tasks which solves this issue along with a whole slew of other ones.