Log error message from authorize.net [#691884]

Currently in uc_recurring_authorizenet_cim_renew(), if the charge fails, the error message ($result['comment']) is thrown out and not logged anywhere. If the renewal fails due to having no reference on the order, there is no error message.

This patch adds a couple of calls to uc_order_comment_save() to assist debugging/customer support.

Comment	File	Size	Author
#5	uc_recurring-cim-log-error-691884-5.patch	1.43 KB	tinker
#4	uc_recurring-n691884-4.patch	785 bytes	DamienMcKenna
#3	uc_recurring.uc_authorizenet.inc-691884-3.patch	584 bytes	RSTaylor
#1	uc_authorizenet.inc_.error_message-2.patch	972 bytes	RSTaylor

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

RSTaylor CreditAttribution: RSTaylor commented 21 January 2010 at 20:47

Status:

Active

» Needs review

File	Size
uc_authorizenet.inc_.error_message-2.patch	972 bytes

repatch, may as well log success message too.

Comment #2

univate CreditAttribution: univate commented 22 January 2010 at 21:37

+++ uc_recurring.uc_authorizenet.inc	Thu Jan 21 15:43:45 2010
@@ -83,9 +84,15 @@
+      uc_order_comment_save($order->order_id, $user->uid, $result['message']);
       return TRUE;
     }
+    else {
+      uc_order_comment_save($order->order_id, $result['uid'], $result['comment']);

Why the difference between the use of $user->uid / $result['uid'] and $result['message'] / $result['comment']?

Powered by Dreditor.

Comment #3

RSTaylor CreditAttribution: RSTaylor commented 25 January 2010 at 15:31

File	Size
uc_recurring.uc_authorizenet.inc-691884-3.patch	584 bytes

After looking at it more closely, on success the uc_authorizenet module does actually log a comment in _uc_authorizenet_cim_profile_charge(), it's just on failure that it doesn't, returning the comment instead (in both 'comment' and 'message').

So in this, $user->uid should only be needed for the case where no reference is found and the function call is skipped.

Comment #4

DamienMcKenna

NH, USA

CreditAttribution: DamienMcKenna commented 30 November 2012 at 03:53

Version:

6.x-2.0-alpha3

» 6.x-2.x-dev

File	Size
uc_recurring-n691884-4.patch	785 bytes

Rerolled.

Comment #5

tinker CreditAttribution: tinker commented 1 July 2013 at 03:59

File	Size
uc_recurring-cim-log-error-691884-5.patch	1.43 KB

Verified the patch in #4 works great but univate's point from #2 is valid. The order comment's user is the person (or process) that enters the comment. It is not the customer's uid. So in this case it should be global user which will show that it was an automated process that created the comment.

Attached patch can be applied using git am uc_recurring-cim-log-error-691884-5.patch

I would mark this RTBC but since I made a change I will leave it up to someone else.