refactor adaptivetheme_system_settings_form() to collapse extra fieldsets provided by modules [#696686]

Just scratching an itch...

I've written a patch to collapse all fieldsets on the theme settings form, not just the ones presently being targeted.

I wanted my Touch Icons fieldset to be collapsible when used with AdaptiveTheme, but this patch will also benefit other modules like DesignKit.

The existing code doesn't put a <div class="*-settings-wrapper"> wrapper around the theme_specific fieldset (I'm not sure why... any special reason?) I've kept that behaviour with my patch, though there doesn't seem to be any harm putting the wrapper around the theme_specific fieldset, too.

Comment	File	Size	Author
#1	adaptivetheme-696686.patch	2.4 KB	andrewmacpherson

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

andrewmacpherson CreditAttribution: andrewmacpherson commented 27 January 2010 at 11:55

Status:

Active

» Needs review

File	Size
adaptivetheme-696686.patch	2.4 KB

here comes the patch...

Comment #2

Jeff Burnz CreditAttribution: Jeff Burnz commented 28 January 2010 at 03:10

Great, you beat me to it, was thinking we should do this also, will review soon (on holiday right now).

Comment #3

Jeff Burnz CreditAttribution: Jeff Burnz commented 3 February 2010 at 13:31

Status:

Needs review

» Fixed

Committed!

Awesome man, I actually simplified it to allow the <div class="*-settings-wrapper"> wrappers for everything, may as well be consistant and this was just an oversight on my part that it wasn't already, good work dude!