Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
For the Views 3 export to work the handler must define all of its options in definition() function. The Slide show style handler fails this in several places, the big one being the 'mode' option.
Attached is a patch to bring it up to snuff.
Comment | File | Size | Author |
---|---|---|---|
#8 | 704096-option_definition-1.patch | 18.56 KB | redndahead |
#1 | views_slideshow_704096-1.patch | 17.71 KB | Scott Reynolds |
Comments
Comment #1
Scott Reynolds CreditAttribution: Scott Reynolds commentedhere is the patch. its pretty invasive.
Comment #2
Scott Reynolds CreditAttribution: Scott Reynolds commentedthere is one small code style error. The #default_value for breakout_fields should have a space after the =>
Comment #3
jrabeemer CreditAttribution: jrabeemer commentedSlideshow now appears for me in the style list.
Comment #4
redndahead CreditAttribution: redndahead commentedIs this views 3 only? or is everything in this patch ok to use with views 2?
Comment #5
jrabeemer CreditAttribution: jrabeemer commentedThis is Views 3. Please review the patch with Views 2.
Comment #6
Scott Reynolds CreditAttribution: Scott Reynolds commentedNo its not Views3 only, its Views2 as well. It just your option_definition was incomplete and it didn't list all the options. This is a problem for the condensed Views3 output only.
It will not negatively affect Views2 at all.
Comment #7
redndahead CreditAttribution: redndahead commentedmarking as critical to look at before release
Comment #8
redndahead CreditAttribution: redndahead commentedHere's a re-roll with the styling fixed. I'll look at the patch in a sec
Comment #9
redndahead CreditAttribution: redndahead commentedAfter looking at this I like this much better. This is a great patch thanks. It has been committed.