Hi.
Thanks for all the great updates to the module. I am however still having one more problem. The HTML button seems to be having problems triggering actions when on Node Edit & Add pages. All works great when viewing the node, yet in those two other states it's not working well. Here's what I have. An HTML button and an Image Button on a node. I have a "display system message" and a "page redirect" action assigned to both of them. Now the image button works fine everywhere and in each scenario. However the the HTML breaks. When click on the above mentioned pages, it obviously tries to do something but it ends up just reloading the page rather than redirecting. Also it gives me this double error message when triggered on a content type which includes a CCK Conditional Field:

warning: in_array() [function.in-array]: Wrong datatype for second argument in /Applications/MAMP/htdocs/drupal/sites/all/modules/conditional_fields/conditional_fields.module on line 803.
warning: in_array() [function.in-array]: Wrong datatype for second argument in /Applications/MAMP/htdocs/drupal/sites/all/modules/conditional_fields/conditional_fields.module on line 803.

This doesn't happen at all with the Image module. So please see if you can get this figured out.

Also small thing, but there's a typo in the Rules integration. It says "Users Clicks a Button". :)

All the best and thanks for your help in advance. :)

Comments

BassistJimmyJam’s picture

BassistJimmyJam CreditAttribution: BassistJimmyJam commented
Assigned: Unassigned » BassistJimmyJam
Status: Active » Fixed

This has been fixed and committed in revision #325606 and will be in the next development snapshot.

bluestarstudios’s picture

bluestarstudios CreditAttribution: bluestarstudios commented

BassistJimmyJam! You're the best ever! Thanks! :)
Ps-a hi from me: I'm a musician myself. ;)

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

GuyPaddock’s picture

GuyPaddock CreditAttribution: GuyPaddock commented
Status: Closed (fixed) » Active

Still seeing the same behavior in the latest Dev release. The rule isn't firing when the button is clicked from the node edit page, but is fired when the button is clicked on the view page.

BassistJimmyJam’s picture

BassistJimmyJam CreditAttribution: BassistJimmyJam commented

Looks like I was missing a call to drupal_add_js(). This has been resolved in revision 353006 and will be in the next dev release.

BassistJimmyJam’s picture

BassistJimmyJam CreditAttribution: BassistJimmyJam commented
Status: Active » Fixed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

  • Commit b2d0539 on 6.x-1.x, 8.x-1.x by BassistJimmyJam: 
    #707336 by bluestarstudios: Corrected the class and id used for HTML...
  • Commit 597e4d5 on 6.x-1.x, 8.x-1.x by BassistJimmyJam:
    #707336 by bluestarstudios: Fixed a typo
  • Commit 1873c70 on 6.x-1.x, 8.x-1.x by BassistJimmyJam:
    #707336 by bluestarstudios: Added in missing js/css files for edit/add...