Hi -

First up, thanks for this great module - very useful.

Having one slight problem though as the twitter API doesn't return old tweets - so if you don't have any tweets in the past week or so, this module displays nothing.

The attached patch makes a few changes so new tweets can be merged with existing ones. It introduces a new variable TWITTER_PULL_REFRESH_DELAY - so you can control how often checks are made for new tweets without expiring items in the cache.

If you set TWITTER_PULL_REFRESH_DELAY to 20, and TWITTER_PULL_CACHE_LENGTH to 0, tweets will be permanently cached, and new items added to them.

Or if you set TWITTER_PULL_REFRESH_DELAY to 0, and TWITTER_PULL_CACHE_LENGTH to 20, the module will check for new tweets when the cache expires (so how it works now).

I hope that sounds OK and maybe a useful addition to this module?

Cheers,

Ben

CommentFileSizeAuthor
#16 twitter_pull-cachefix-716958-16.patch3.5 KBKleve
#15 twitter_pull-cachefix-716958-15.patch3.3 KBPeter Törnstrand
#12 twitter_pull-cachefix-716958.patch3.57 KBtinkerbelle
#8 twitter-pull-8.patch3.34 KBAlan D.
#2 twitter_pull.patch4.32 KBben_scott
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

irakli’s picture

irakli CreditAttribution: irakli commented

This is a very interesting point. Thank you much for reporting. Will try to work something out as soon as I can.

ben_scott’s picture

ben_scott CreditAttribution: ben_scott commented
FileSize
twitter_pull.patch4.32 KB

Hi irakli

Sorry, I seem to have failed to attach the patch. Here it is...

Cheers,

Ben

sunchaser’s picture

sunchaser CreditAttribution: sunchaser commented

would love to see this patch commited. lovely module , much needed patch ...
thanx for the hard work !

gennadiy’s picture

gennadiy CreditAttribution: gennadiy commented
Version: 6.x-1.0 » 6.x-1.1

Hi Irakli,

Thank you so much for this needed module. Unfortunately I do have the very same problem with Twitter Pull module, so I assume that you didn't have time to make a fix yet. Also when you will have some more time for the Twitter Pull module if I could suggest to add Twitter Basic Auth and OAuth that will help those who are hitting rate limit for the anonymous calls as per this document:
http://dev.twitter.com/pages/rate-limiting

Thank you and Best Regards,
Gennady

arithmetric’s picture

arithmetric CreditAttribution: arithmetric commented

@gennadiy,
I've created a new issue for your suggestion to add support for OAuth authentication: #893394: Add support for OAuth authentication

dmetzcher’s picture

dmetzcher CreditAttribution: dmetzcher commented

Having this issue as well. The tweets disappeared if they were older than a certain date (more than three or four weeks ago, it seems). I posted a new update to Twitter and that single update appeared via Twitter Pull, but none of the older tweets prior to that appeared.

Alan D.’s picture

Alan D. CreditAttribution: Alan D. commented
Version: 6.x-1.1 » 6.x-1.x-dev

bump

Alan D.’s picture

Alan D. CreditAttribution: Alan D. commented
FileSize
twitter-pull-8.patch3.34 KB

An updated, but untested patch against 6.x-1

djschoone’s picture

djschoone CreditAttribution: djschoone commented

would love to see it in the release. Will test it right away!

djschoone’s picture

djschoone CreditAttribution: djschoone commented

Question: where do i find the cached tweets in the database? Should there be a cache_pulled_tweets table? Wrong DB :(

djschoone’s picture

djschoone CreditAttribution: djschoone commented

#716958-8: Old tweets disappear seems to work correctly

tinkerbelle’s picture

tinkerbelle CreditAttribution: tinkerbelle commented
Version: 6.x-1.x-dev » 7.x-2.x-dev
FileSize
twitter_pull-cachefix-716958.patch3.57 KB

This is a crucial feature for a site I am working on with an infrequently updated Twitter feed, so I'm reviving this rather ancient issue. I'm currently testing an updated version of this patch, which seems to work fine so far, and would love to see this functionality added to the module!

I'm attaching my attempt at a proper patch against 7.x-2.x-dev, but I should note that I basically have no idea what I'm doing :)

bmunslow’s picture

bmunslow CreditAttribution: bmunslow commented
Issue summary: View changes

Hi,

Sorry to revive the issue again, but are there any new improvements in this matter?

It'd be great to be able to store older tweets and merge them with the newer ones. The 1 week limit still applies and it is quite annoying to get empty twitter boxes...

The patch proposed in #12 does not apply to 7.x-2.0-alpha2 ...

axelpezzo’s picture

axelpezzo CreditAttribution: axelpezzo commented

I really need to patch this bug. In my case the latest tweets about last month aren't display.

Peter Törnstrand’s picture

Peter Törnstrand CreditAttribution: Peter Törnstrand commented
FileSize
twitter_pull-cachefix-716958-15.patch3.3 KB

Re-roll of patch from #12 against 7.x-2.0-alpha2+3-dev

Kleve’s picture

Kleve CreditAttribution: Kleve at Happiness commented
FileSize
twitter_pull-cachefix-716958-16.patch3.5 KB

Update of patch from #15 to print cached tweets.