Hi,

I have got this module to work fine. It works for all the blocks, that is with the exception of the Dynamic Display Block. Therefore I know the block.tpl.php file is set-up fine and working. I can enter a class, hit save and it saves, except for on the ddblock where it doesn't get saved.

I am guessing here, I am assuming this is a conflict between the two modules. Can anyone else confirm this, or possibly tell me what I have done wrong?

I have tried both the release and dev versions of this module with no luck.

Cheers,
Nick

CommentFileSizeAuthor
#10 block_class-1.3-717270-10.patch323 bytesVanD
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

hvalentim’s picture

Experiencing the same here. Works with all blocks but Dynamic Display. It never saves the class.

Todd Nienkerk’s picture

Status: Active » Postponed (maintainer needs more info)

I'm able to add classes to dynamic display blocks without a problem. However, I can't get it to work with "instances." I suspect this is because these "instances" aren't really blocks in the truest sense.

I'm not familiar enough with this module to fully understand why this is happening. Can someone provide some insight?

nickbits’s picture

Hi Todd,

Just so I am clear in my head, what do you define as an instance?

Nick

Todd Nienkerk’s picture

Nick: By "instance," I'm referring to the things you create using DDB's "instances" tab.

nickbits’s picture

Hi Todd,

Obvious, don't know why it didn't click before. So the question then is, if it is the instance, then presumably this is an issue with the DDBlock module?

Nick

Todd Nienkerk’s picture

Nick: This is either a bug in DDBlock or "by design," meaning that DDBlock's "instances" are completely different from real blocks and aren't supposed to support other modules' additions to the block configuration interface. If that latter is the case, I may be able to add a check to Block Class that refuses to display the classes field for DDBlock's "instances."

nickbits’s picture

Hi Todd,

I know it's not by design as others have said they have got ddblock and block class to work together fine. I would therefore assume it is a bug with ddblock. I will file a bug report with ddblock, and see what happens.

Thanks for the help,
Nick

g7w’s picture

Status: Postponed (maintainer needs more info) » Active

Dynamic Display Block (DDB) and Block Class version: block_class 6.x-1.2
play well together

Upgrade to Block Class version: block_class 6.x-1.3
and DDB is broke.

Why?
I have no clue.

Is this a DDB problem?
It wasn't until the recent block class security fix.

VanD’s picture

I can confirm the same as #8 g7w

Block Class 6.x-1.2 - Works with ddblock
Block Class 6.x-1.3 - Does not work with ddblock

VanD’s picture

Status: Active » Needs review
FileSize
323 bytes

Here is a patch I made to fix the issue for now.
Pretty simple fix.

berenddeboer’s picture

Status: Needs review » Needs work

Have to reject patch in #10 as we should not save data in the validate function.

berenddeboer’s picture

Category: bug » feature

Marking this as feature request, as it is not a bug in block class.

berenddeboer’s picture

Priority: Normal » Minor
DYdave’s picture

Status: Needs work » Fixed

Hi guys,

It seems this issue hasn't been moving for a while now.

I have tested with the latest versions of the Dynamic display block (7.x-1.0 and 7.x-1.x-dev) and the Block Class (7.x-2.0, 7.x-1.2, 7.x-2.x-dev and 7.x-1.x-dev) modules and I was unable to reproduce this issue.
Basically, it doesn't seem like there would be any conflict anymore and the two modules seem to be working fine together now.

Therefore, I allowed myself to mark this issue as fixed for now, but feel free to re-open it, or post a new ticket, at any time if you have any further objections or still encounter any issues with these two modules (we would surely be happy to hear your feedback).

Please let me know if you would have any further comments, feedback, questions, issues, objections, suggestions or concerns on any aspects of this ticket in general, I would be glad to provide more information or explain in more details.

Thanks again to everyone for your help, reviews, feedback and comments on this issue.
Cheers!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.