Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Hi,
I have got this module to work fine. It works for all the blocks, that is with the exception of the Dynamic Display Block. Therefore I know the block.tpl.php file is set-up fine and working. I can enter a class, hit save and it saves, except for on the ddblock where it doesn't get saved.
I am guessing here, I am assuming this is a conflict between the two modules. Can anyone else confirm this, or possibly tell me what I have done wrong?
I have tried both the release and dev versions of this module with no luck.
Cheers,
Nick
Comment | File | Size | Author |
---|---|---|---|
#10 | block_class-1.3-717270-10.patch | 323 bytes | VanD |
Comments
Comment #1
hvalentim CreditAttribution: hvalentim commentedExperiencing the same here. Works with all blocks but Dynamic Display. It never saves the class.
Comment #2
Todd Nienkerk CreditAttribution: Todd Nienkerk commentedI'm able to add classes to dynamic display blocks without a problem. However, I can't get it to work with "instances." I suspect this is because these "instances" aren't really blocks in the truest sense.
I'm not familiar enough with this module to fully understand why this is happening. Can someone provide some insight?
Comment #3
nickbits CreditAttribution: nickbits commentedHi Todd,
Just so I am clear in my head, what do you define as an instance?
Nick
Comment #4
Todd Nienkerk CreditAttribution: Todd Nienkerk commentedNick: By "instance," I'm referring to the things you create using DDB's "instances" tab.
Comment #5
nickbits CreditAttribution: nickbits commentedHi Todd,
Obvious, don't know why it didn't click before. So the question then is, if it is the instance, then presumably this is an issue with the DDBlock module?
Nick
Comment #6
Todd Nienkerk CreditAttribution: Todd Nienkerk commentedNick: This is either a bug in DDBlock or "by design," meaning that DDBlock's "instances" are completely different from real blocks and aren't supposed to support other modules' additions to the block configuration interface. If that latter is the case, I may be able to add a check to Block Class that refuses to display the classes field for DDBlock's "instances."
Comment #7
nickbits CreditAttribution: nickbits commentedHi Todd,
I know it's not by design as others have said they have got ddblock and block class to work together fine. I would therefore assume it is a bug with ddblock. I will file a bug report with ddblock, and see what happens.
Thanks for the help,
Nick
Comment #8
g7w CreditAttribution: g7w commentedDynamic Display Block (DDB) and Block Class version: block_class 6.x-1.2
play well together
Upgrade to Block Class version: block_class 6.x-1.3
and DDB is broke.
Why?
I have no clue.
Is this a DDB problem?
It wasn't until the recent block class security fix.
Comment #9
VanD CreditAttribution: VanD commentedI can confirm the same as #8 g7w
Block Class 6.x-1.2 - Works with ddblock
Block Class 6.x-1.3 - Does not work with ddblock
Comment #10
VanD CreditAttribution: VanD commentedHere is a patch I made to fix the issue for now.
Pretty simple fix.
Comment #11
berenddeboer CreditAttribution: berenddeboer commentedHave to reject patch in #10 as we should not save data in the validate function.
Comment #12
berenddeboer CreditAttribution: berenddeboer commentedMarking this as feature request, as it is not a bug in block class.
Comment #13
berenddeboer CreditAttribution: berenddeboer commentedComment #14
DYdave CreditAttribution: DYdave commentedHi guys,
It seems this issue hasn't been moving for a while now.
I have tested with the latest versions of the Dynamic display block (7.x-1.0 and 7.x-1.x-dev) and the Block Class (7.x-2.0, 7.x-1.2, 7.x-2.x-dev and 7.x-1.x-dev) modules and I was unable to reproduce this issue.
Basically, it doesn't seem like there would be any conflict anymore and the two modules seem to be working fine together now.
Therefore, I allowed myself to mark this issue as fixed for now, but feel free to re-open it, or post a new ticket, at any time if you have any further objections or still encounter any issues with these two modules (we would surely be happy to hear your feedback).
Please let me know if you would have any further comments, feedback, questions, issues, objections, suggestions or concerns on any aspects of this ticket in general, I would be glad to provide more information or explain in more details.
Thanks again to everyone for your help, reviews, feedback and comments on this issue.
Cheers!