Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
The default messages "existing_request" and "existing_relationship" contain the name of the requestee and requester. However, when the default message is retrieved through user_relationships_ui_get_message, no relationship object is passed along. Therefore, the function doesn't call theme('username',...) on both values. This leads to a non-unified user experience, because sometimes the username is shown as a link and sometimes not.
Comments
Comment #1
advseb CreditAttribution: advseb commentedIn general, before printing the username, it should always call theme('username', $user_obj), because this will ensure a more consistent look of the module output. There are many other occurences in this module, where the theming function is not used.
Comment #2
alex.k CreditAttribution: alex.k commentedCould you post a patch that resolves the issues if you have fixed them? Thanks.
Comment #3
rburgundy CreditAttribution: rburgundy commented+1 subscribing, this would be great!
Comment #4
rburgundy CreditAttribution: rburgundy commentedI marked #714778: make 'username' on send request use themed username as a duplicate
Would someone be able to provide a patch that will fix this issue?
Thanks!
Comment #5
Bilmar CreditAttribution: Bilmar commentedI am moving over from #714778.
Would anyone please be able to look into correcting the consistency of the username used throughout the module?
I think a major one is the send request confirmation page uses '%name' => $requestee->name for the username where as the other pages for approve/disapprove/cancel uses (from user_relationships_ui.forms.inc):
I unfortunately don't have programming skills to fix this but will be up for extensive testing of all the pages where the username is shown as soon as a patch may be available.
This is a great module and I hope to see it further develop!
Thank you very much in advance.
Comment #6
alex.k CreditAttribution: alex.k commentedFixed, committed in http://drupal.org/cvs?commit=336696.
Comment #7
Bilmar CreditAttribution: Bilmar commentedwow, thanks for the quick action alex.k!
i will try the latest dev tonight and report back if any issues.
thanks again!
Comment #8
Bilmar CreditAttribution: Bilmar commentedconfirmed that it shows the themed username now =)
I noticed in the committed changes that the old '%name' => $requestee->name is still in the array, but not sure if it should/shoudnt be. Thanks again!
Comment #10
rickh CreditAttribution: rickh commentedSorry to repoen this, but is there maybe a patch available as this is quite a problem for me at the moment. Any help would be greatly appreciated. Thanks
Comment #11
alex.k CreditAttribution: alex.k commentedThis is available in the current -dev release, can you try it out?
Comment #12
Bilmar CreditAttribution: Bilmar commentedChanging status back to Fixed as it is in the latest dev.
The occurrences of username that I was looking at are themed usernames now.
Thanks alex.k!
Comment #13
YK85 CreditAttribution: YK85 commentedHi,
I also needed the themed username and confirmed the committed patch added this.
Thanks!