This might be a handy feature, or it might merely be confusing as you don't get that option on editing the vocab.

CommentFileSizeAuthor
#4 719522.user_terms.show-on-vocab-admin.3.patch951 bytesyeputons
#2 719522.user_terms.show-on-vocab-admin.2.patch905 bytesyeputons
#1 719522.user_terms.show-on-vocab-admin.patch938 bytesjoachim
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

joachim’s picture

joachim CreditAttribution: joachim commented
Status: Active » Needs review
FileSize
719522.user_terms.show-on-vocab-admin.patch938 bytes

Here is a patch anyway.

Opinions on this?

yeputons’s picture

yeputons CreditAttribution: yeputons commented
Status: Needs review » Patch (to be ported)
FileSize
719522.user_terms.show-on-vocab-admin.2.patch905 bytes

First thing I noticed:

  $vids = variable_get('user_terms_vocabs', /* !! */ array() /* !! */);

$vids should be array, not a string, if user_terms_vocabs wasn't defined.
The next bug: we should add comma only if $form[$vid]['types']['#value'] is not empty.
Fixed patch is attached.

joachim’s picture

joachim CreditAttribution: joachim commented
Status: Patch (to be ported) » Needs work 
+++ user_terms.module	17 Jun 2010 02:16:00 -0000
@@ -299,6 +299,21 @@ function user_terms_save_profile(&$edit,
+    if (!empty($val)) $val .= ', ';

Well spotted!

But always put the if block in braces and on its own line.

Powered by Dreditor.

yeputons’s picture

yeputons CreditAttribution: yeputons commented
Status: Needs work » Needs review
FileSize
719522.user_terms.show-on-vocab-admin.3.patch951 bytes

Like this?