Hi.
I have a forum structure like
Container1
-Forum1
--Subforum1
--Subforum2
When I look to forum list I see number of topics/posts only in forum1 itself, they do not include topics/posts from subforum1 and subforum2. Same with new topics.
I've tried to change advanced_forum.naked.forum-list.tpl.php
like this:

        <td class="forum-number-topics">
          <div class="forum-number-topics">
          <?php
            $topics_num = $forum->num_topics;
            if (!empty($forum->subforums)):
                foreach ($forum->subforums as $forum_id => $sub_forum):
                    $topics_num += $sub_forum->num_topics;
                endforeach;
            endif;
          print $topics_num;

but it did not change number..

So, how it can be done?
All I want - to see on the forum list topics, posts number and last messages from all forums in hierarhy.

Comments

This is something I'd like to have in the module but it's not a very high priority for me since I don't use subforums. I'd love to see someone contribute a patch, but it needs to be tested that it doesn't slow down what is already a very slow page.

Michelle

subscribing - I've a similar need. If I get it working I'll post the solution here.

subscribing

subscribing

has anyone figured this out? I have a forum that acts like a category since there are so many subforums. I would much rather keep it this way and show the total posts in a forum including subforums, and would be willing to sacrifice some speed to accomplish it! Thanks

First of all, I want to thank Michele for her great work on version 2 of advanced forum.

I created a code that works pretty good.
My code deals only forums that have sub-forums.
It allows:

  • Displays in the Parent Forum of the total subjects (forum and subforums).
  • Displays in the Parent Forum on total number of posts (forum and subforums).
  • Displays in the parent forum last position between the Forum and these sub-forums.

The code in question to be placed in file advanced_forum.naked.forum-list.tpl.php on line ~69, after <?php else: ?> :

    <?php
   
// START Supplement for forums that contain sub-forums (Complete: Number of subjects, number of posts and when the last post).
     
if ($forum->last_post->timestamp == NULL) {
       
$forum->last_post->timestamp = 0; // If there is no post (avoids creating an error below).
     
}
      foreach (
$forums as $k1 => $v1) {
        if (
$v1->parents[0] == $forum->tid) {
         
$forum->num_topics += $v1->num_topics; // Increment the variable with the value of the sub-forum.
         
$forum->num_posts += $v1->num_posts; // Increment the variable with the value of the sub-forum.
         
if ($v1->last_post->timestamp != NULL) {
            if (
$v1->last_post->timestamp > $forum->last_post->timestamp) { // Find the last post between the forum and these sub-forums.
             
$forum->last_reply = $v1->last_reply;
            }
          }
        }
      }
   
// END Supplement for forums that contain sub-forums (Complete: Number of subjects, number of posts and when the last post).
   
?>

Use with caution... developed by an amateur ;)

Thanks. My French is rusty but the code doesn't look too complicated. Not sure when I'll have a chance to look at this but maybe it will help folks in the mean time.

Michelle

But nothing! I would be very happy if my code can help people.

Ps: I translate what my code ... My English is not great either.

Greetings.
Clement

Which file did you add this to, please? You didn't mention that in the post. Thanks.

EDIT: I found it.. sorry bout that. Works good for me.

HI

The code works good but only if Subforum does not contain another Subforum.

I've got this forum structure:

Container
- Forum <- does NOT show counter because of Subforum level
-- Subforum <- show counter
--- Subforum <- show counter

- Forum <- show counter
-- Subforum <- show counter
-- Subforum <- show counter
...

The counter works good inside Subforum but on Forum level (wich contains two subforums level) the counter does not work and shows 0

How to modify the code in order to get it working with more Subforum levels?

Effectively, there is still a problem with the forums that are over 2 levels.

I made a new code, normally it should fix this problem.

Greetings.
Clement

    <?php
   
// START Supplement for forums that contain sub-forums (Complete: Number of subjects, number of posts and when the last post).
     
if ($forum->last_post->timestamp == NULL) {
       
$forum->last_post->timestamp = 0; // If there is no post (avoids creating an error below).
     
}
      foreach (
$forums as $k1 => $v1) {
        if (
$v1->parents[0] != NULL) {
         
$terms_parents = array_reverse(taxonomy_get_parents_all($v1->parents[0])); // Table of the newsgroup hierarchy (mandatory for forums using more than 2 levels).
         
if ($forum->tid == $terms_parents[1]->tid) {
           
$forum->num_topics += $v1->num_topics; // Increment the variable with the value of the sub-forum.
           
$forum->num_posts += $v1->num_posts; // Increment the variable with the value of the sub-forum.
           
if ($v1->last_post->timestamp != NULL) {
              if (
$v1->last_post->timestamp > $forum->last_post->timestamp) { // Find the last post between the forum and these sub-forums.
               
$forum->last_reply = $v1->last_reply;
              }
            }
          }
        }
      }
   
// END Supplement for forums that contain sub-forums (Complete: Number of subjects, number of posts and when the last post).
   
?>

Hi Clément

Unfortunately, this does not work.

I tested this and applied th code in the file advanced_forum.naked.forum-list.tpl.php but the Number of subjects, number of posts and when the last post counter don't show anything;

Container
-Forum1 <- does not show
-- Forum2 <- shows
--- Forum3 <- shows

Help would be appreciated

I do not understand, it works with me. Here's the test I do:

Container
-Forum 1 -> Contains a topic
--Forum 2 -> Contains a topic
---Forum 3 -> Contains a topic

Display :

Container
-Forum 1 -> 3 topics
--Forum 2 -> 2 topics
---Forum 3 -> 1 topics

So for me it works.
Have you placed the code after:

      <tbody>
        <?php if ($forum->description): ?>
          <tr class="container-description">
            <td colspan="5">
              <?php print $forum->description; ?>
            </td>
          </tr>
        <?php endif; ?>
  <?php else: ?>

If this is the case, it would be interesting to see the picture forums. You have to use print_r() to do this.

    <?php
   
print '<pre>';print_r($forums);print '</pre>';
   
// _ARM_ DEBUT Complément pour les forums qui contiennent des sous-forums (Complète : Nombre de sujets, nombre de posts et date du dernier post).
      // Code pour les forums avec plus de deux niveaux de profondeur.
     
if ($forum->last_post->timestamp == NULL) {
       
$forum->last_post->timestamp = 0; // Si il n'y a aucun post (évite de créer une erreur plus bas).
     
}
      foreach (
$forums as $k1 => $v1) {
        if (
$v1->parents[0] != NULL) {
         
$terms_parents = array_reverse(taxonomy_get_parents_all($v1->parents[0])); // Tableau de la hiérarchie des forums (obligatoire pour les forums utilisant plus de 2 niveaux).
         
if ($forum->tid == $terms_parents[1]->tid) {
           
$forum->num_topics += $v1->num_topics;// Incrémente la variable avec la valeur des sous-forums.
           
$forum->num_posts += $v1->num_posts;// Incrémente la variable avec la valeur des sous-forums.
           
if ($v1->last_post->timestamp != NULL) {
              if (
$v1->last_post->timestamp > $forum->last_post->timestamp) { // Trouve le dernier post entre le forum et ces sous-forums.
               
$forum->last_reply = $v1->last_reply;
              }
            }
          }
        }
      }
   
// _ARM_ FIN Complément pour les forums qui contiennent des sous-forums (Complète : Nombre de sujets, nombre de posts et date du dernier post).
   
?>

You should understand what is happening.

Greetings.
Clément

I try your patch clement, and it's work great for me.

PS in French : Merci pour ton travail :)

Thank you, I'm glad that you will render service code!

Patch #6 works for me. #11 and #13 do not work! I have no containers, I have a lot of Forums with a lot of subforums.

How can this be solved:

If there are 5 new posts in a forum, the forum list's shows: "5 new".
If there are 5 new posts in a subforum, the forum list (parent) does not show this! How can this be added, so that users know, there are new messages in one of the subforum?

@DrupalFan2: This is still an active feature request. There is some code in this issue that you can try to make work. Alternately, you can write your own solution or hire someone to do it. This isn't a real big priority for me since I don't use subforums so may be a while before I get to it.

Michelle

Maybe Clément knows the answer, how to solve the problem with "new posts". Patch #6 could be extended.

Sorry, I could not answer before.

I no longer use this module, I preferred to finish integrating my old forum (phpBB3) in Drupal. It must surely be a solution to this problem every animal but apparently I did not find.

Greetings.
Clement

Title:Topics/posts calculation with subforums Better handling of containers, forums, and subforums
Version:6.x-2.0-alpha2» 6.x-2.x-dev
Category:feature» task

Ok, I don't really need this but I decided to take it on anyway. While I appreciate the attempt above, that's not the path I'm going to take. Adding this to my alpha 4 blocker list.

Doing this sanely is going to require imposing some sanity on the forum taxonomy. Currently you can do crazy stuff like put a forum at the root and add a container under it and a forum under that and then another container and then another forum an maybe a container along side. It's just nuts. Trying to allow for all of that makes very messy code. Here's what I'm thinking of imposing and I'd like to know if this will mess up anyone's structure:

  1. Containers must be at the root.
  2. Forums can only be at the root if you have no containers at all.
  3. Forum depth is limited to two. That is, you can have a forum that contains a sub forum that contains a sub-sub forum but no farther.

That should cover 99% of the cases out there I would think. Any thoughts?

Michelle

That would work for me!

Hi Michelle!

Here my answers:

1) Containers only on the main page, it's normal.

2) Maybe i didn't understand something, containers have forums and forums have sub-forums no ?

So containers without forum ? If i miss something tell me.

3) I think it will be fine to have just a depth limited to two.

Thanks again for your work.

subscribing

Going to push this off another alpha. I really need to get this out and this is too big of a project for right now.

I have this situation:

Container1
-SubContainer1
--Forum1
---SubForum1
---SubForum2
-SubContainer2
--Forum2
---SubForum3
---SubForum4
-Forum3
-Forum4
...

AF doesn't like subcontainers at all so I'll be watching this issue...

Maybe we can put containers and forums in separate templates?

similar to #25. I'm watching as well. :)

Tentatively setting this as an alpha 4 blocker again. Sorry for the waffling. The problem is that I really need to release alpha 4 and this one is a messy one that I'm not entirely sure how best to tackle. At this point, there are two other things blocking A4, one of which I'm not directly involved with. If I can get some movement on this before that one gets settled, I will try to get it in A4. If this ends up being the last thing holding up release, I will likely push it over to A5.

Michelle

Pulling #1055002: Containers inside of forums not supported in here as well.

Michelle

I've spent some time tonight looking at big forums, the biggest I can find, and I can't find any that aren't covered by #20. Drupal's structure is just so loose that it's a nightmare to get a template to cover it all and, I suspect, most forum apps don't allow that. If it wasn't for #25, I'd say that's the plan and go with it... But I don't want to blow off troky after all he's done for AF so I'll think on it some more.

@troky: Any chance you have a mockup of what that would look like visually? Since I can't find any examples of subcontainers anywhere, it's hard to even picture what this would look like.

Michelle

@Michelle: I don't have anything yet. Like you said, strutcure is loose so there are many things to think of. However, core forum displays structure from #25 and AF doesn't and that should be solved somehow. This is not an easy task and it will require much testing so I would push it to A5.

Core does it by putting everything in one big table and just indenting x pixels * depth. I suppose one option is I could support that template as well and have a switch between the nicely formatted one for sensible structures and core's template if you wanna get whacky. That's more work for me, though, so not sure I want to go that route.

The reason I'm considering this at all for A4 is because it's a real WTF if you have subforums with new posts in them. But solving that problem requires me to settle this other issue of what AF will be supporting, first. It's all wrapped up together. As I said, though, it depends how long this takes. I'm not going to let this issue delay A4 and will kick it to A5 if the other two issues get done and we're just waiting on this.

Michelle

Sub

What about this idea: displaying sub-categories like regular forums only with different style (let's say different background color or something). In that case table structure would be retained. For example with structure in #25:

/forum shows:
Container1
-SubContainer1
-SubContainer2
-Forum3
-Forum4
/forum/SubContainer1 shows:
-SubContainer1
--Forum1
---SubForum1
---SubForum2
...

I'll try to setup such structure and show it on live site.

I was sick last night and had an idea on how to do this while I was laying in bed. No time to write it up now. Will try to do that this evening. Just hang on for a bit. :)

Michelle

Sorry, between being sick and being gone, I haven't gotten to this, yet. It's definitely a priority for me, though. The way I'm thinking of doing this is a big enough change that I'd like to get it into Alpha 4 so will be working on it ASAP.

Michelle

Hi Michelle,

First of all, I'd like to thank you for the great module. I'm making the switch from vbulletin to drupal (AF) forums and that never would've happened without AF. Secondly, I believe I am having the same issue as being addressed above and just want to confirm that my particular instance will be covered in this Alpha 4/5 release.

Forum Index (e.g. /forum-> No post counts of subforums
-Container (e.g. /forum/lounge) -> No post counts of subforums
--Forum (e.g. /forum/lounge/offtopic -> Post count of subforums
---Subforum

Thanks!

Well, I can't guarantee it but I am working on it.

Michelle

Made good progress tonight. Nothing committable, yet, but I'm feeling more confident about getting this done and into Alpha 4.

Michelle

StatusFileSize
new18.93 KB

Did a patch for what I have so far as a preview. Do not use this in production! Not only is it unfinished and still buggy but it may be insecure. I whacked large chunks of display preparation code and rewrote them and haven't checked to make sure I didn't introduce security holes. I'll try to work on it more this weekend. Please don't bother reporting bugs in it at this point... I'm well aware of a bunch of things that are wrong with it. I mostly posted it for the curious and also as a backup because I don't like having large changes uncommitted.

Michelle

Awesome! Seems like you're making good progress. On the road this weekend but I'll test when I get back to a real computer

StatusFileSize
new19.04 KB
new12.35 KB

Michelle, what is your idea of displaying sub-containers?
I ported this patch to 7.x (and fixed some minor bugs) and what I get is in attachment.

I wanted to see this displayed on forum frontpage:

Computers & Internet (collapsible table)
-Internet (container shown as regular forum with or without cumulative stats)
-Hardware (container shown as regular forum with or without cumulative stats)
-Programming & Design (regular forum)
-Software (regular forum)
...
-Security (regular forum)
Consumer Electronics (collapsible table)
...

Expanded sub-containers doesn't make much sense, right?

Anyway, I welcome your patch and I think you are on good way :)

Oh, please don't try to port this yet. I'm not even close to being done with it. That was only a couple hours of work. It's going to take several more before I'm even ready for people to test this. I probably shouldn't even have posted a work in progress but I get nervous about having something uncommitted that would be hard to redo and I don't have any VCS except Drupal's CVS.

Michelle

Don't worry. I was just curious :)

Ok. I just don't want to waste your time trying to keep pace with porting this. It's still very actively under development. I tend to develop iteratively... Making one use case work, then refining to make more work, figuring things out as I go along. I just work better by "try it and see" than "make a plan and implement it" so my in process code will likely bear very little resemblance to the final product. :)

Michelle

Requesting this be pushed to alpha 5, since we have lots of features fully implemented in -dev that aren't in alpha 3 and this isn't close yet.

subscribing. :)

Just an update... I'm still working on this. Can't share what I have so far because I can't figure out how to make git do a simple diff like CVS can. Hopefully I'll be able to commit it when it's done... Otherwise I may not be able to get any further on AF until I get to DrupalCon and can corner some git geek to explain this stuff to me.

Michelle

git diff > xyz.patch

more

Hi michelle!

I give you a little help with git.

Use cd /directory to be in the right place.

when it's done write this :

git init

It will create a git repertory.

To add files write this :

git add .

Write now you will be able to make a patch.

Modify your files and now you just have to write this to create the patch :

git diff --no-prefix > something.patch

Let me know if you didn't understand something :)

Hope this help.

StatusFileSize
new36.08 KB

Thanks, troky / MasterChief. This git really is crazy. These are the docs for making a patch on the project page:

Creating a patch
For a discussion of this recommend patch sequence, see the Patch contributor guide.
git checkout -b [description]-[issue-number]

Make your changes. Note the change in syntax for issue-related commit messages. See the Commit messages page for details.
git add -A
git commit -m "Issue #[issue number] by [comma-separated usernames]: [Short summary of the change]."
Roll the patch.
git status
git fetch origin
git rebase origin/6.x-2.x
git format-patch origin/6.x-2.x --stdout > [description]-[issue-number]-[comment-number].patch

So I got on IRC to find out if there was any way I could make a patch without committing and catch said to do "git diff master > foo.patch" which gave me an error. At that point I gave up and went to bed and woke up with a link to a stack overflow page from chx that had even more complicated stuff on it. Thankfully you guys answered and it looks like "git diff > xyz.patch" works just fine and is just as easy as the CVS option. Whew!

So, here's the latest. It's not done, yet, but it's getting pretty close. I've tested it with a fairly convoluted forum/container setup and it seems to handle everything I throw at it but it's quite possible I missed something. I would appreciate it if some others could test as well. Theming obviously needs some work since I haven't accounted for the extra "row" on top. I also need to double check that all the post counts and everything are still accurate. Collapsible containers are broken but WorldFallz can look at that now that she has the HTML to work from.

The method I chose for displaying child post counts is, by design, different than most stand alone apps I've used. The data is there to do it the other way at the style level if people really want to. If there's enough interest, I may be able to make it an option rather than people having to customize the templates but that won't be until after Alpha 4 if at all.

Michelle

Status:Active» Needs review
StatusFileSize
new64.84 KB

Ok, I think this is good to go, now. This is a pretty massive patch and ended up with some bad scope creep, I'm afraid. Changing the CSS of the forum listing led to changes elsewhere and fighting with inheriting from Silver Bells in Blue Lagoon so I made that subtheme off Naked, which meant adding in all the images... Kinda got away from me. The good news is that this should be the last of the really major changes. Most of what's left before 2.0 is fairly discrete features. I'll likely do some cleanup work between now and then but hopefully nothing quite this extensive.

Anyway, I'd appreciate it if I could get some other eyes on this before I commit it. I've been looking at it so long I could be missing something critical and not even realize it.

Thanks,

Michelle

Oh, one other thing... The patch isn't going to include images. Just copy them from Silver Bells into Blue Lagoon for testing.

Michelle

Oh, just realized I forgot to hide the "Icon" column header. I'll get that in before it's committed.

Michelle

That's one big patch :)

I know, I'm sorry. I'm really trying to not do monster changes now that we've branched but this one just had tentacles all over. It just kept growing and growing no matter how much I tried to stay focused on just the forum list. :( Looking over the rest of the to do list, though, I don't see anything else that's likely to be so massive. That was a big reason why this needed to get into Alpha 4. I want this to be the last really painful upgrade and work on smaller, faster alphas and get to beta ASAP.

Has anyone tried it, yet? I know I posted it before bed US time and it's only morning but maybe some Europeans...? I'd like to get this committed soon so I can work on the last of the bugs and get this alpha out before DrupalCon.

Michelle

I've ported it to 7.x. After fixing some syntax errors it's looking good. Patch broke my collapsed containers code so I need to fix that, too. I will report back soon when I test it on some more complicated container/forum structure.

Oh, yes, this definitely breaks the collapsible containers. WorldFallz said she can work on a new patch for that soon.

Michelle

Ok, fixed collapsible containers and it seems that you did it just as I wanted... :)

Bugs:
- check for "border: border: " in css
- in tpl.php missing few semicolons in <?php print something?>
- remove t('Icon') as you noticed already

Suggestions:
- th.forum-icon width should be fixed to some pixels (we know icon width and padding/margins, right?) because it can look weird if streched too much
- wrap forum-table in separate div that will be used for collapsing because sliding table doesn't work as desired. For example:

<div class="forum-table-wrap">
  <div class="forum-table-superheader">...</div>
  <div id="forum-table-1">
    <table class="forum-table forum-table-forums">...</table>
  </div>

I've updated http://d7.minixchange.com/forum
I need to tweak js a little and that's it.

That sounds reasonable. I didn't get to it tonight but will tomorrow.

Thanks for the testing!

Michelle

StatusFileSize
new22.69 KB
new26.82 KB

More suggestions:

- displaying statistics for (container) sub-forums slows down forums display a lot and this should be an configurable option. I am talking about 150 vs 50ms in queries for small/medium forum (30k topics)

- displaying container forums as sub-forums at all doesn't have much sense to me because there is forum->sub-forum structure for that purpose. I am using containers to minimize page load time and display size when user opens forum frontpage. Imagine what would happen if one has 200 forums.
Displaying forum->sub-forums with statistics is fine.

I would like to hear what other people think about this...

Keep in mind that not getting the stats for subforums/containers means that there is no visual indication on the main forum page that there are new posts unless the new post is at the root level forum, which takes us back to where we started.

Containers don't display as subforums; they are on a separate line. And that can be edited out of the template if not wanted. It's easier for people to take stuff out than to add stuff that isn't there so I usually have all the options as the default.

Michelle

Keep in mind that not getting the stats for subforums/containers means that there is no visual indication on the main forum page that there are new posts unless the new post is at the root level forum, which takes us back to where we started.

I am not sure I want any visual indication for subcontainer ('Internet' or 'Hardware' in my example) on main page. It is performance killer. I am not asking to remove this behavior, just to make it optional. I can't remove statistical calculations by changing template...

It is question why use container->forum and not forum->subforum structure. I am using containers to hide everything beneath it and if I want to display indications/statistics I use forum->subforum structure.

In your case, there is not difference between containers and forums with depth>1 while at depth=0 they have expected table->row relation.

I don't have a problem making it optional. That bit of code is segmented out and should actually be pretty easy to make an option. I'm just warning you that using that option will mean someone will look at the front page of the forum and think there's no new posts if they are all in subforums.

Dealing with sub-subcontainers visually is a pain. I wanted them included by default for completeness but making them distinctive visually would have been really messy. That's why I went the "Subcontainers:" route. It's easy enough to get rid of that in the template for those who don't want it. I think sub-subcontainers are pretty edge case anyway.

Michelle

I believe you don't understand me :)

Let's say we have some really big general board with subcategories (among others) 'Physics' and 'Fashion' that both have bunch of subforums (and sub-subforums). There aren't really many people that are interested in both categories so 'Physics' users don't care if there are new post in 'Fashion' category and vice versa but showing both 'new posts' indication on main page impacts performance a lot. That's not a common situation but it is possible and should be considered.

I see it this way:
If someone wants to see 'new posts' indications in top category forums he/she will use root->category->forum->subforum structure.
If someone wants to do what I wrote above he/she will use root->category->subcategory->forum->subforum structure.
And no option/setting is needed.

Your code is very good because it offers both possibilities with small changes ;)

Anyway, let's finish this as you planned and I'll make patch after alpha4 to show what I want to achieve.

Version:6.x-2.x-dev» 7.x-2.x-dev
Status:Needs review» Patch (to be ported)

Ok, I committed / pushed everything except #60. I'm still not quite following but let's deal with that in a separate issue post Alpha 4. I'm running out of time... Will be pretty swamped this weekend and I leave on Monday. Doesn't look like I'll be able to get A4 out before the con but hopefully during.

Michelle

Status:Patch (to be ported)» Fixed

Committed to 7.x.
I will reopen issue after A4.

Version:7.x-2.x-dev» 6.x-2.x-dev
Category:task» bug
Status:Fixed» Active

Bah, found a couple bugs while I was testing collapsible containers.

* Subcontainers on the main page aren't linked correctly.
* Subsubcontainers with no forums don't have a placeholder.

Michelle

Are you sure subcontainers are linked wrong? On my test page, I see sub-subcontainers linked wrong, but subcontainers are linked correctly. Subsubcontainers have a link like this: container/99. That one is easy to fix in theme.inc, search for container/ and replace with forum/ (one occurrence). It works for me at least.

As for empty subsubforums having no placeholder, I tried an empty container in the forum root, and it spawns an error in both the forum-list pre-process function and style. Is this by design? If so, then containers shouldn't be allowed to be empty in general, IMHO. Allowing it everywhere except in root is somewhat contradictory. Maybe you should just issue a warning upon the user creating an empty container?

Yeah, I meant subsub there, sorry. Ah, I bet that got caught when I did a search/replace. Thanks for finding it.

Anything that spawns errors isn't by design. ;) Just means I haven't tested enough combinations, yet, and missed something. AF isn't involved in forum creation at all; it just needs to be able to handle whatever weirdness is thrown at it.

Michelle

Ok I understand.
As for the errors, I meant to ask something along the lines of: "Is it by design, that an empty container doesn't work." I remember you wrote something about limitations on the forum hierarchy. I doubt, however, that anyone is going to make a forum container and then NOT use it :) So IMHO this is not critical.

My original plan was to impose limits on what you could do and still have AF work properly. But then I gave it more thought and realized I could accommodate all sorts of weirdness if I molded what core gives me into a standard pattern. So the intent, at the moment, is to allow any combination of forums and containers. If there's some weird edge case that I can't make it work for, so be it. But, for now, my goal is to deal with anything the site builder wants to create.

Michelle

Ah, ok that clears it all up, thanks. Pretty cool feature too, though!

Status:Active» Fixed

Ok, fixed the bad link. Thanks a.ross.

Sub-subcontainers not having a placeholder when empty, I'm just leaving for now. Not sure that's really a bug. More a design decision on what should you do in that case. Going to punt and come back to it if someone has a specific complaint / suggestion. It's seriously edge case, anyway.

Michelle

Status:Fixed» Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Version:6.x-2.x-dev» 7.x-2.x-dev
Category:bug» support
Status:Closed (fixed)» Active

hey, sorry to re-open.. but did this ever make it anywhere. It sounds like it did but it doesn't seem to be all there.

i have a nested taxonomy like this: http://screencast.com/t/PjpBnJpuCVa1

my guess would be that this is everything required to make nested forums (i.e. subforums)

but i get this at /forum: http://screencast.com/t/qGYQNHCfj

i sort of expected to see some sort of nesting, no? like some of the pngs in this thread. or is this theming that is left to the user to sort out?

i do see that when i pick my top forum (Civil) that it does show the subforums: http://screencast.com/t/WkP3XXTP which is good

and if i pick one of the subforums, the add new topic it does correctly tag with correct term hierarchy.

so it looks like everything is here except some form of nesting in the top Forum display; maybe i expected too much except that the thread shows this as we'd expect. also, i don't even see any sort of class hierarchy in the html so tricky even to do some form of simple css to show this correctly.

i'm sure i am missing something.. :(

Version:7.x-2.x-dev» 7.x-2.0
Category:support» bug
StatusFileSize
new32.29 KB
new51.1 KB
new50.7 KB

This problem remains for a site's forum path. I am marking it as a bug because the resultant UI is misleading to the end user.

Here is a simple example. First, the structure, where "Member's Forums" is a top-level container; all others are forums.

Forums structure

Next we navigate to SITE-URL/forum. The page does not show containment of the forums by the "Member's Forums" container.

Forums path

Once we're inside that container, everything is ok.

The container itself

yup, that works.. @Bob, didn't realize there was a Forums page where i could create containers. thanks.

Update:

Regardless of whether the top-level item is a Container or a Forum, nesting of its children is not shown. Rather, they appear in the display as peers of their parents.

Is this a case of bad parenting or of rebellious children?

:)

StatusFileSize
new79.68 KB

Hi, sorry, I don't understand, How I can fix issue (for Drupal 7 and AF 7.x-2.0), when my forums don't counting post and topics of subforums? Please give me a number of comment with patch, which correct it.

PS I was attached image, please look at it.
PPS Sorry for my bad english.

Is there a fix to this?

I have a situation where I have a parent forum, and several subcontainers under that, with subforums under these subcontainers. Right now it is displaying 0 for the post count, but I would like it to show the real post count for these subcontainers. Otherwise, my users will not know if there are new posts in these subcontainers.

Hm, I wonder what happens when there is more than 1 container in the forum root? Could someone try?

Status:Active» Fixed

Please try 7.x-2.x-dev.
Subcontainer/subforum rendering on frontpage should be ok now.

Subcontainer/subforum and parent post count fixed as well.

Status:Fixed» Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Version:7.x-2.0» 6.x-2.x-dev

I just updated to latest dev for 6 but still the parent doesnt show posts and topics of the subforums. Is there a working patch for that?
structure is
-Container
--forum
---subforum

Thank you

Version:6.x-2.x-dev» 7.x-2.3
Priority:Normal» Major
Status:Closed (fixed)» Active

I have the same problem with 7.x-2.3. Forum has:
container
-forum1
--forum2
---forum3
and i can't see last posts and links to new in subforms are broken (only domain/#new). When i am in forum1 i see last post but it is not last post (i see last post from forum2 but post in forum 3 is real last post)

Regards

Issue summary:View changes
Priority:Major» Normal
Status:Active» Needs review
StatusFileSize
new1.48 KB
new25.52 KB

I have a forum structure like
Container1
-Forum1
--Subforum1
--Subforum2

Last Drupal and AF
I have a problem which the comment # 79 describes
In oder to solve it, I wrote a patch that displays the last comment in terms of time in a column “last post”. It displays the last message of not only the forum, but also sub-forums, if they exist.
You can see this forum on the screen after applying the patch.

Last post in subforum

Version:7.x-2.3» 7.x-2.x-dev
Status:Needs review» Needs work
Issue tags:+Needs manual testing, +Page loading performance

+      $query->join('forum_index', 'f', 'n.nid = f.nid AND f.tid IN (:tids)', array(':tids' => $tids));
+      $query->join('node_comment_statistics', 'ncs', 'n.nid = ncs.nid');
+      $query->join('users', 'u', 'ncs.last_comment_uid = u.uid');

We can`t use here full joins without limits...
Try to generete (devel_generate) 100K users, 100K nodes, 100K taxonomy terms and You will get 30+ seconds query
This one needs to be optimized