The code in plugins/tasks/search.inc is quite problematic. I don't know what it's trying to achieve, but it duplicates the tabs such that the core search behavior of switching searches between tabs is gone, forces a 'Search' tab to show up which may not be desired, and in general seems half baked since all the comments refer to 'node view '.
The menu alter seems to run even if the search panel page is not enabled, and there seems to be no setting to disable it.
Perhaps this would be at least partially resolved by changing this code:
// automatically disable this task if it cannot be enabled.
variable_set('page_manager_search_disabled_' . $name, TRUE);
to:
// automatically disable this task if it cannot be enabled.
variable_set('page_manager_search_disabled_' . $name, FALSE);
or otherwise fixing the logic so that the auto-disabling works.
Comment | File | Size | Author |
---|---|---|---|
#10 | Picture 2.png | 30.2 KB | grendzy |
#9 | 722246-fix-search-tabs.patch | 5.53 KB | merlinofchaos |
#8 | 722246-fix-search-tabs.patch | 4 KB | merlinofchaos |
Comments
Comment #1
merlinofchaos CreditAttribution: merlinofchaos commentedWhat is half-baked is how search module handles its tabs (which is incredibly poorly).
That said, perhaps you should read the code you're suggesting changing, since you want to make the auto-disable an auto-enable.
Comment #2
merlinofchaos CreditAttribution: merlinofchaos commentedOk, so I see what you mean about the search keywords not being carried through. (I actually had no idea they were meant to be. That's interesting).
I don't see the duplicated tabs in my install.
Comment #3
pwolanin CreditAttribution: pwolanin commentedThe tabs are duplicated in the sense of both getting the tailing % and not. That is, they are duplicated in the database, not visually. Sorry for not being clear about that.
The auto-disabling is not working - Perhaps what is missing is a ! in the check.
I know search module is a pain - just trying to avoid have it break even more especially in combination with apachesolr.
Comment #4
pwolanin CreditAttribution: pwolanin commentedcross link to that issue queue: #593814: Conflict with Panels/Page Manager Module
Comment #5
lijiele CreditAttribution: lijiele commentedI have the same problem.
The easy way i fixed like that :
mv search.inc search.inc.bak
and then go to the page admin/build/modules , click 'Save configuartion' .
Comment #6
lijiele CreditAttribution: lijiele commentedI have resolved it by use the module weight and menu_alter.
For example, my module name is [mymodule]
1.fmymodule.install
2.mymodule.module
Comment #7
merlinofchaos CreditAttribution: merlinofchaos commentedPart of this problem is solved by http://drupal.org/node/722246
Comment #8
merlinofchaos CreditAttribution: merlinofchaos commentedHere's a patch that I think fixes this.
Comment #9
merlinofchaos CreditAttribution: merlinofchaos commentedCommitted this patch (slightly improved from #8). Marking for 7.x porting.
Comment #10
grendzy CreditAttribution: grendzy commentedBy altering the values of {menu_router}.tab_root and tab_parent, it causes the title of the search page to change to "Home". (see #817810: Search page title changes to Home)
Comment #11
merlinofchaos CreditAttribution: merlinofchaos commentedThat doesn't invalidate this patch. It means we need a followup. Let's do that at http://drupal.org/node/817810
Comment #13
merlinofchaos CreditAttribution: merlinofchaos commentedAll of the 'to be ported' patches got merged in during the porting sprint in September.
Comment #14
mstef CreditAttribution: mstef commentedStill seeing this with the latest 6.x..
Looking into it now
Comment #15
merlinofchaos CreditAttribution: merlinofchaos commentedThere's too much going on in this issue, including at least 2 links to other issues, for a single sentence (seeing this) to be helpful. Let's try a new issue if you've got some specifics. It can reference back to this one. Plus, the last comment re-opened it saying 6.x but didn't change the version.