Am I wrong, or does the module includes (and commits in Drupal.org CVS) files licensed under GPL License V3, where they should be licensed under the same license used by Drupal?

Comments

Category:support» bug
Status:Active» Needs work

Yes - it should use Libraries API.

See also #579950: Commercial version SWF.

Title:Module includes files licensed under GPL License v3Move to Libraries API to remove Flowplayer binaries and GPL 3 code
Category:bug» task
Priority:Normal» Critical

I'd love for this move to happen! We'll have to really document the installation of the plugins (like RTMP) as they're downloaded seperately from the main Flowplayer package.

Status:Needs work» Active

well, start by moving the files out of the archive and reading from sites/all/libraries/flowplayer3.

that's a good start.

and btw, the flowplayer bundles are outdated too...

I created a patch for this, which allows to set the library path to flowplayer manually or with the use of the libraries module. I added a README.txt and removed the flowplayer files.

I will leave the priority to critical because we need to remove the flowplayer plugin from the module!
SEE: http://drupal.org/licensing/faq Question 4, 5 and 10.

To outsource the flowplayer will also enable it to update. But be careful, the last version provided by this module was 3.1.5. There could be some compatibility issues with newer versions. This is *not* part of this issue. If there are compatibility issues, please open a new issue.

Status:Active» Needs review
StatusFileSize
new36.02 KB

Version:6.x-1.x-dev» 7.x-1.x-dev
StatusFileSize
new40.25 KB

Here is a reroll of the patch against 7.x-1.x. I added a few more helper functions to get the path to the .swf and .js files individually, since the flowplayer package itself keeps the version number in the file names so we can't just specify them directly.

@jrreid: Not sure, but maybe just look once for the libraries and store them with variable_set(). And refresh this variable only when showing the settings page + list the files on the settings page.

Hey, jrreid -- I've managed to apply the patch -- but I'm having a tough time configuring the library path. I've added the files to my /sites/all/libraries directory and added the path to the module configuration, but no dice. I am desperately trying to add my own branding, but to no avail. I've tried via array in the video module, in the flowplayer module, and using the JS api.

StatusFileSize
new231.17 KB

Recreated patch with --binary option. Without --binary option, running git apply complains about the binary files.

The patch expects the Flowplayer SWF to have the format 'flowplayer-*.swf'. It also expects flowplayer-3.2.10.min.js to be in the examples sub-folder. After extracting Flowplayer Commercial into sites/all/libraries/flowplayer...

  • Rename 'flowplayer.commercial-3.2.11.swf' to 'flowplayer-commercial-3.2.11.swf'
  • Move 'flowplayer-3.2.10.min.js' to 'example/flowplayer-3.2.10.min.js'

Andy, I am having a bit of difficulty applying the patch -- is there a different procedure for applying binary patches?

Applying the patch appears to work fine by just doing "git apply flowplayer-libraries-722604-10.patch".

Subscribing to this issue. What have been decided since then? Flowplayer is going to be in Libraries' folder?