Using drupal_queue for importing, there is a major failure on hook_cron(). This happens because the variable $queue is never instantiated.
Attached is the patch.
Would like to look into have FeedsScheduler::queue() always return FALSE when it shouldn't use the queue instead of NULL. But that doesn't have to get in this fix.
Without this patch, importing fails completely when you have drupal_queue module enabled.
Also, drupal_queue_get() function does the _include() callback already so no need for that inside this class. Doesn't get in the way and its not broken but when you port to D7 this will make it easier.
Comment | File | Size | Author |
---|---|---|---|
feeds_queue_fail.patch | 954 bytes | Scott Reynolds | |
Comments
Comment #1
alex_b CreditAttribution: alex_b commentedFixed: http://drupal.org/cvs?commit=335538
Thank you.
Comment #2
alex_b CreditAttribution: alex_b commentedI do prefer NULL vs object as return value to FALSE vs object. The latter would be mixing return value types.
What are your thoughts?
Comment #3
Scott Reynolds CreditAttribution: Scott Reynolds commentedYa I think your right. I interrupted $this->queue() as equilivent to $this->useQueue() which it isn't. Its creating an object and returning it (which of course it says in the php doc :-D). It is more consistent to have it return NULL.