I would like to ask if the project Paging module has plan for migrating to Drupal 7? I am interested to help migrating Paging module to Drupal 7.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Gurpartap Singh’s picture

It'll definitely be developed for Drupal 7.

arpeggio’s picture

I see. thank you.

becw’s picture

I'd like to help update this module for Drupal 7. There are a couple changes in D7 that should influence the update path. Thinking about it, I realize that my ideas might diverge too far from how this module works in Drupal 6. In the interest of building on what already exists, here's a brain-dump of some of the things I've run into with making this module useful on D7:

  • In Drupal 7, nodes aren't required to have a body field. This may mean that paging should be a field formatter rather than a per-node setting. The field formatter API is solid and you can configure formatters independently on each field. It would make a lot of sense to be able to chose "paged text" as the formatter for text_long and text_with_summary fields. The issue this raises is that there are several pager settings that are input settings, rather than output, and they would not be appropriate in a field formatter: the "paging separator widgets" and "display page names interface".
  • The other way to address nodes not having a predictable body field would be to provide a "Page on field:" selector widget in the paging configuration, which admins could use to select whichever field was acting as the body field. Underneath, though, this would be very similar to using a field formatter to make a configuration specific to a field instance, except that it would have to handle view mode and teaser logic.
  • Teaser handling has changed in Drupal 7 as well. There's a new "text with summary" field, which allows you to create a summary/teaser that is not simply a trimmed version of the full text. Display modes are more fleshed out, so configuring the display of fields on the "full" and "teaser" node displays is more obvious/sensible/common. I think that this means a lot of the teaser logic can be bypassed.
  • Additionally, if paging is a field formatter, I suspect that the input filter is no longer necessary--in D6 it is used to trigger paging on certain fields, but if we are configuring paging on a per-field basis, we'll know whether to page or not regardless of the input filter (since we can use field API hooks).

I'm sure I'll run in to other things, and I'm not sure whether I will pursue a more divergent update or try to stick closely to the D6 implementation, but if you have any input one way or the other please let me know!

anavarre’s picture

Hi,

Any update on this ?

Thank you

superflyman’s picture

subscribing

camdarley’s picture

subscribing

arnieswap’s picture

Any update? We can help testing the D7 port.

Dalabad’s picture

subscribing

Agileware’s picture

For a drupal 7 solution you can try the smart paging module.

I upgraded a site from d6 using paging to d7 using smart paging and it worked with no problems.

arnieswap’s picture

Seems like this module is not going to D7. Smart Paging looks impressive, will give it a try.

Lugir’s picture

subscribing and try #9

endiku’s picture

subscribing

RmrJmrGrl’s picture

Would like to see a D7 version as well!

webankit’s picture

+1

webankit’s picture

FileSize
33.64 KB

I ran a simple coder upgrade
(not working)

zamir’s picture

subscribing

lsancheztapia’s picture

subscribing

basicmagic.net’s picture

subscribe

lsancheztapia’s picture

Hello,

I found this: http://drupal.org/project/smart_paging . I will check.

dalin’s picture

Would be great to see a D7 module of this. I've probably wasted 25hrs with big architectural issues in Smart Paging module.

damiandab’s picture

sunscribing

jenlampton’s picture

Title: Is the project Paging module has plan migrating to Drupal 7? » Will the paging module be upgraded to Drupal 7?

I'm going to need this module for Drupal 7 in a few weeks. Has anyone made any progress on a 7.x branch yet?

jenlampton’s picture

Assigned: Unassigned » jenlampton

I'm starrting on this now. The code lives in a sandbox for the time being, but I'd love to get a 7.x branch started here, and I'll provide some patches :)

Here are some thoughts and notes I wanted to jot down while upgrading:

1) should paging have it's own admin permission? It's currently using 'administer site configuration'
2) where should we put the admin settings in the menu? I guessed admin/config/content/paging.
3) Right now paging just works on nodes, but we could expand this to work for any entity type.
4) I left out the vertical tabs on the admin interface, since this is not the correct usage of verticaltabbage.
5) I added a selector on the settings page so you can choose which field the pagebreaks should come from.
6) I'm removing support for different pager styles, only theme_pager will be called.
7) positioning above or below for the pager is now replaced with hook_field_extra_fields()
8) Removed the AJAX page reload feature, but others can add it back if it's missed.
9) some settings are now global rather than per content type (separator string, number of pagers per page)
10) removing the Page names interface part. that will need to be added back in later.
11) removing pager insert widget. that will need to be added back in later if it's missed.
12) adding WYSIWYG support, as per #269039: Provide WYSIWUG API module support for Paging

Okay, I'm calling it a night, but I've got a good start. I added // @TODOs in the comments wherever I changed something that's going to need an upgrade path fro D6 => D7.

As of now, this version is working for me: http://drupal.org/sandbox/jenlampton/1636102

N4R4YAN’s picture

following this, this module is perfect but it really needs a port to drupal 7 :)

Frank Ralf’s picture

FileSize
10.08 KB

This is for those not familiar with Git. I just pulled the code from http://drupal.org/sandbox/jenlampton/1636102 and zipped it so more people will have the chance to test it ;-)

Frank Ralf’s picture

Status: Active » Needs review

Setting status to "needs review".

Frank Ralf’s picture

FileSize
9.25 KB

I ran the above code through Coder and made some minor amendments. The module works as promised. It would be great if this could be made an "official" D7 release soon so more people could review the code.

Maks’s picture

This module is perfect but it really needs a port to drupal 7!!!!

VenDG’s picture

Could someone in charge please make this an official version 7 release. Thanks.

perisdr’s picture

I installed the module, enabled the paging filter for filtered html and full, enabled the paging for my content types, made sure that the pager was set to visible.

Nevertheless I cannot break my nodes into multiple pages. I can see the <!--pagebreak--> in my source when editing the node but thats all. I checked again all the configuration steps in case I missed something but couldn't find anything.

Then I thought maybe there is a problem since I have the Global redirect enabled which has problem with multipage nodes. I disabled it but still nothing. Has anyone been able to run the 7.x version? I was hoping it could work with global redirect (because smart paging doesn't) but I can't make it to work at all. I' ll try to set it up again in a clean drupal installation just to make sure that it does indeed work. Maybe it has conflict with another module.

jenlampton’s picture

Assigned: jenlampton » Unassigned

I've made some changes to fix a minor PHP notice I was getting: http://drupal.org/sandbox/jenlampton/1636102

@Frank Ralf would you be willing to provide patches there, or commit directly to my sandbox project? I'd love to get some of your improvements included in version control so that your work is not lost :)

@N4R4YAN and @Maks this module has a port to Drupal 7. It's currently in my sandbox (http://drupal.org/sandbox/jenlampton/1636102) and marked needs review. Would you please review it for us? :)

@VenDG I have contacted the module owner to ask if I can help get an official release out or Paging. We'll see what he says.

@perisdr I would check the order of your filters under admin > config > content authoring > text formats. And for the Filtered HTML input format, you also need to make sure that you have allowed HTML comments by adding <!--> as a tag, in the list of "Allowed tags".

(Also un-assigning from myself.)

Frank Ralf’s picture

Hi Jen,

Thanks for the feedback. If you could make me co-maintainer of your sandbox-project I'll see what I can contribute (as soon as I find the time).

tia
Frank

EDIT:
And have you tried to contact the maintainers of the Paging module to make you (co-) maintainer?

Gurpartap Singh’s picture

I have added @jenlampton as a maintainer for 7.x version.

Frank Ralf’s picture

Great. Thanks!

@jenlampton
Will you move your sandbox code over here or will you keep it as a separate project?

jenlampton’s picture

@Frank Ralf I am moving it over here. No need for another project :)

Frank Ralf’s picture

@jenlampton
Great!

jenlampton’s picture

Version: 6.x-1.x-dev » 7.x-1.x-dev

soon, grasshoppers!

Frank Ralf’s picture

Hm, the 7 branch is available from Git but still doesn't show up on the project page. As there's still a master branch lying around this might be the culprit and should be moved to a major version branch according to Moving from a master to a major version branch.

Git's default master branch should not be used and no downloadable releases can be tied to that branch. Use 6.x-1.x, 7.x-1.x or 8.x-1.x as your main development branch (see below).

(see Release naming conventions)

As soon as the 7 branch is visible to the general public I would suggest closing this issue.

value’s picture

Any updates on an official D7 release? Looks close. I'm already stuck converting a ton of fields and Image data would be awesome not to have to tackle configuring Smart Paging on top of my headaches :D

Ah I see there is a branch available but not on the Project page.

chegor’s picture

Hi all!
May be someone has an idea how to hide some cck fields on the second, third etc. pages of the pager? (such as main image for a node, which I don't need to display on other than first page)
Thanks in advance

forestmars’s picture

After reading through this thread it's not clear to me what Paging module offers that Smart Paging module doesn't, ie why it needs a D7 version when Smart Pagingg already seems to do this. (I did see #20 which has credence however it's not clear to me what the actual issue is with Smart Paging...?)

jenlampton’s picture

Title: Will the paging module be upgraded to Drupal 7? » D7 port of Paging

This issue should be about the Drupal 7 port of paging. (updated title)

I think the real question is why the author of smart_paging felt it necessary to create a duplicate module back in 2010, instead of working on Paging. Paging has been around since 2005, and smart_paging was created in 2012. I for one would love to see the two merged in the future, and if Gurpartap Singh agrees, would welcome arpeggio in the issue queue over here :) Can you please open an issue in that queue and point Robert over here?

As to why this module should continue to exist, the one thing I can see being super important is the upgrade path. Does smart_paging provide a path from drupal 6 paging module?

@Frank Ralf the new branch was added for cleaning up the issue queue, there is no code there yet, but that all changes this weekend :) I will close this issue as soon as you can grab a dev tarball.

jenlampton’s picture

Category: feature » task
Status: Needs review » Fixed

Initial D7 port is in the git repo now under the 7.x branch.
Closing this issue. :)

Frank Ralf’s picture

Hi Jen, thanks for your efforts!

However, the problem mentioned at #38 still seems to be unsolved.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Frank Ralf’s picture

Status: Closed (fixed) » Active

@#42

I hope to get the ball rolling by posting #2023135: Joining forces with Paging module? ;-)

jenlampton’s picture

Status: Active » Closed (fixed)

The problem in 38 is fixed, please see the project page to download the 7.x dev branch.