Line Break Converter filter should ignore line breaks like the following:

<a href="/" title="This link points to...
Drupal homepage">Drupal homepage</a>

The above produces...

Drupal homepage">Drupal homepage

CommentFileSizeAuthor
#16 filter.module-16.patch2.6 KBtadityar
#14 filter.module-14.patch2.6 KBtadityar
#8 filter.module-8.patch2.79 KBpuradata
#7 filter.module_7.patch699 bytespuradata
#7 filter.test-7.patch465 bytespuradata
#7 filter.module-autop-7.patch2.45 KBpuradata
#5 filter.module.patch627 bytesStevenPatz
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

magico’s picture

magico CreditAttribution: magico commented

Still happening.

hingo’s picture

hingo CreditAttribution: hingo commented
Version: x.y.z » 6.0-beta1

This seems to have gotten no attention since Version field was left unspecified.

StevenPatz’s picture

StevenPatz
he/him
Primary language English
Location Alexandria VA
CreditAttribution: StevenPatz commented
Version: 6.0-beta1 » 7.x-dev
StevenPatz’s picture

StevenPatz
he/him
Primary language English
Location Alexandria VA
CreditAttribution: StevenPatz commented
Status: Active » Needs review
Issue tags: +Quick fix
FileSize
filter.module.patch627 bytes

Something like this?

Status: Needs review » Needs work

The last submitted patch failed testing.

puradata’s picture

puradata CreditAttribution: puradata commented
FileSize
filter.module-autop-7.patch2.45 KB
filter.test-7.patch465 bytes
filter.module_7.patch699 bytes

Left the status "work to be done" for the following reasons.

1. I rerolled the patch that failed testing, but could not verify that it fixes anything.

2. Submitted a different patch that fixes the sample problem , but it is not an elegant solution.

 <a href="/" title="This link points to...
Drupal homepage">Drupal homepage</a>

3 . Added a test in filter.test to check that we don’t add any brreak tags to an attribute value.

puradata’s picture

puradata CreditAttribution: puradata commented
FileSize
filter.module-8.patch2.79 KB

Merged 3 patches from comment 7 to 1.

kenorb’s picture

kenorb CreditAttribution: kenorb commented

I've got similar problem: #506112: wrong line wrapping on drupal_wrap_mail() in mail.inc

tadityar’s picture

tadityar CreditAttribution: tadityar commented
Issue summary: View changes
Status: Needs work » Needs review

setting for review

The last submitted patch, 7: filter.module-autop-7.patch, failed testing.

The last submitted patch, 7: filter.module_7.patch, failed testing.

Status: Needs review » Needs work

The last submitted patch, 8: filter.module-8.patch, failed testing.

tadityar’s picture

tadityar CreditAttribution: tadityar commented
Status: Needs work » Needs review
FileSize
filter.module-14.patch2.6 KB

re-rolled patch in 8

Status: Needs review » Needs work

The last submitted patch, 14: filter.module-14.patch, failed testing.

tadityar’s picture

tadityar CreditAttribution: tadityar commented
Status: Needs work » Needs review
FileSize
filter.module-16.patch2.6 KB

Trying again!

Status: Needs review » Needs work

The last submitted patch, 16: filter.module-16.patch, failed testing.