Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
When I create a view with 'Comment: View link' field, link is displayed but it ignores the division into pages and does not add '?page=page_num' to the URL.
The following patch solves this problem. Please review.
Comment | File | Size | Author |
---|---|---|---|
#3 | views_handler_field_comment_link.patch | 1.34 KB | ershov.andrey |
Comments
Comment #1
dawehnerIts just implemented how drupal core does it :)
This was a long long problem in drupal until drupal7. There is a fix in drupal7, but i don't think that this will be fixed in drupal6.
I think this shouldn't be fixed in views.
Comment #2
esmerel CreditAttribution: esmerel commentedAlso, no patch is attached.
Comment #3
ershov.andrey CreditAttribution: ershov.andrey commentedSorry, there is my patch.
Comment #4
ershov.andrey CreditAttribution: ershov.andrey commentedComment #5
merlinofchaos CreditAttribution: merlinofchaos commentedAside from poor code style (spacing is wrong) this patch runs a query for every field rendered. Unless that is impossible to avoid, we should not do that, it is highly inefficient. We use pre_render() to try to run a single query when we can.
Comment #6
esmerel CreditAttribution: esmerel commentedNo work done on patch for more than 3 months.
Comment #7
jcisio CreditAttribution: jcisio commentedNo patience?
Comment #8
paolomainardi CreditAttribution: paolomainardi commentedAny new about this problem ? On D5 we was using this one: http://drupal.org/project/comment_redirect
They say that in D6 6.x-dev version the problem is now solved, with the last dev version i see that this issue is still there.
Thanks a lot.
Comment #9
esmerel CreditAttribution: esmerel commentedNot unless someone wants to work on that patch, no.
Comment #10
paolomainardi CreditAttribution: paolomainardi commentedFinally, i've just solved the problem using Permalink module, that seems to be the same approach taken into D7.
Comment #11
MustangGB CreditAttribution: MustangGB commented