Hi Sean,
Superb module. very well thought through.
the only thing holding me back using this is the lack of plain text email support. i.e. a lot of people at some of my sites regularly use blackberries or mobile devices to check their email on the move, so the HTML only aspect is a drawback.
Any plans to add an option to send PLAIN TEXT as well as HTML emails?
Or alternatively, add a plain text (multipart) to the HTML email - which means those receiving emails without HTML support, can view the plain text part of the email. Such as
---plaintext----
%name thought you might be interested in the following page at the %sitename site:
%sender_message
%node_title
%node_link
cheers
%footer/advert
=================================
hope that makes sense
Dub
Cheers
Dub
Comment | File | Size | Author |
---|---|---|---|
#8 | forward.zip | 2.6 KB | friedman |
#7 | forward.zip | 2.54 KB | friedman |
#3 | forward.theme.74723.patch | 1.87 KB | plumbley |
#2 | forward.theme.20061208.patch | 1.61 KB | kb5ql |
#1 | forward.module.20061208.patch | 2.88 KB | kb5ql |
Comments
Comment #1
kb5ql CreditAttribution: kb5ql commentedI have created a patch file for both the forward.module and forward.theme that adds two new enhancements:
1. Create a flood control for the amount of people you can SEND TO for any given email this page request.
2. Create the ability to send multipart/mime messages for plain text/html in the same message.
Once you patch these two files, you can play around and try and simply do a plain-text email only if you prefer.
PS -- MAKE SURE you change the url http://www.foo.com for the forward.theme patch
Good Luck.
Comment #2
kb5ql CreditAttribution: kb5ql commentedHere is the forward.theme file
Comment #3
plumbley CreditAttribution: plumbley commentedWorks for me - many thanks.
Here's an updated patch for
forward.theme
that usesurl(...)
to generate the appropriate links for the plain text email.With this patch it is no longer necessary to edit the patched file to change any "foo.com" URLs before using.
Best wishes, Mark.
Comment #4
donquixote CreditAttribution: donquixote commented+1
Plaintext is more reliable and more trustworthy, it's cheaper to modify, and the client can customize it himself quite safely. Moreover, it is easier to design in a constrained design space, with no colors, font sizes etc.
Or did I miss something, and there already is a plaintext option?
Comment #5
sadist CreditAttribution: sadist commentedI can't seems to find any option to use plain-text instead of html. Anyone to guide me here?
Comment #6
seanrDoesn't currently exist, but I'll be happy to add it. If anyone can help contribute to a patch against the current version, that'll certainly speed things up - I'm very busy with a lot of other stuff at the moment.
Comment #7
friedman CreditAttribution: friedman commentedHere's a patch to implement plain text e-mail against 6.x-1.19. It also fixes a few minor errors that I found.
I adapted this from the patch submitted above in 2006/7 using the forward.tpl.php model.
Changes:
The notification message was being cleaned regardless of the allow html setting.
Changed 'Oranization' to 'Organization'
Removed the border from logo.
Removed the nl2br function from thankyou message -- why was that included? It doesn't play well with ckeditor.
You might want to replace more html constructs from the plain text in forward_clean() in forward.tpl.php
One problem remains which i haven't yet tracked down. The "The configuration options have been saved." message is appearing twice. If you see an easy fix for this please let me know. Otherwise the changes work fine.
Comment #8
friedman CreditAttribution: friedman commentedIt appears that the call to system_settings_form_submit in forward_admin_settings_submit() is not needed so
it's commented out and now the confirmation message appears once. Revised patch attached.
Comment #9
friedman CreditAttribution: friedman commentedTest patch in #8
Comment #10
friedman CreditAttribution: friedman commentedTest patch in #8
Comment #11
john.oltman CreditAttribution: john.oltman commentedThanks, I'll take a look at this tonight. One factor to consider is keeping the D6 and D7 versions in synch with regards to plain text support.
Comment #12
john.oltman CreditAttribution: john.oltman commentedApplied spelling correction and confirmation message fixes to D7 branch, thanks for posting those. Will review plain text soon.
Comment #14
john.oltman CreditAttribution: john.oltman commentedIn 7.x and 8.x this can be accomplished via hook_mail_alter
Closing