Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Looks like the CKeditor wrapper must have a bug. the isNode() method is never invoked on the plugins, seems it never accurs?
As really a lot of users start to use CKeditor (iam not..), iam marking it as urgent
Comment | File | Size | Author |
---|---|---|---|
#10 | wysiwyg-DRUPAL-6--2.ckeditor-isnode.10.patch | 1.02 KB | sun |
#9 | wysiwyg-DRUPAL-6--2.ckeditor-isnode.9.patch | 999 bytes | sun |
#8 | wysiwyg-DRUPAL-6--2.ckeditor.748888.8.patch | 1 KB | TwoD |
Comments
Comment #1
miro_dietikerConfirm this to be an issue. Missing e.g. active icon mark for current markup item.
Comment #2
TwoDI did not make a call to isNode in partly because CKEditor seems to have moved away from highlighting buttons depending on the selection. Note that their own image button does not highlight when an image is selected, but it does add a context menu item. Another reason was that at the time I could not figure out how to change a button's state. (Later turned out that buttons do not have states, but the commands associated with them do, and that I now know how to change.)
I did not consider this critical at the time because isNode() should do no processing which changes anything on its own, it's invoked as often as on each keystroke to determine button state, but I can see that some plugins may rely on it internally as well.
We already have an issue about making isNode and invoke receive the same parameters here: #613944: data.node object not present in FCKeditor/CKEditor, so I'll mark this a duplicate of that (can't send the same parameters if it's never invoked hehe).
Comment #3
TwoDComment #4
EugenMayer CreditAttribution: EugenMayer commentedAs explained in the other issue, i cant see how this is a dublicate of the empty data.node issue.
Because this issue is not about isNode(data) .. that data is empty or the wrong element..no..its about that isNode is NEVER called :)
Comment #5
TwoDUn-duplicating the issue and instead noting that this issue needs to be kept in sync #613944: data.node object not present in FCKeditor/CKEditor so that this isNode implementation gets the same element which will be present in invokes'
data.node.
Comment #6
EugenMayer CreditAttribution: EugenMayer commentedThanks TwoD!
Comment #7
sunComment #8
TwoDWrote this patch a while ago (originally for #613944) but forgot to post it here...
Comment #9
sunSlightly revamped that code :)
Comment #10
sunSorry, converted @TwoD's code wrongly.
Comment #11
TwoDYep, now it works again. =)
Comment #12
sunThanks for reporting, reviewing, and testing! Committed to all branches.
A new development snapshot will be available within the next 12 hours. This improvement will be available in the next official release.