Add more date format string to views_date_sql_format [#755342]

Comment	File	Size	Author
#7	views_date_sql_format_ext_3.patch	1.32 KB	jcmarco

#4	views_date_sql_format_ext_2.patch	1.3 KB	jcmarco

#2	views_date_sql_format_ext.patch	1.32 KB	jcmarco

#1	views_date_sql_format.patch	370 bytes	jcmarco

Comment #1

jcmarco CreditAttribution: jcmarco commented 28 March 2010 at 12:34

File	Size
views_date_sql_format.patch	370 bytes

Log in or register to post comments

Comment #2

jcmarco CreditAttribution: jcmarco commented 28 March 2010 at 15:07

File	Size
views_date_sql_format_ext.patch	1.32 KB

I have extended the most usual date formats

From:
http://us.php.net/manual/en/function.date.php
http://dev.mysql.com/doc/refman/5.0/en/date-and-time-functions.html
http://developer.postgresql.org/pgdocs/postgres/functions-formatting.html

Log in or register to post comments

Comment #3

merlinofchaos CreditAttribution: merlinofchaos commented 28 March 2010 at 15:27

Status:

Needs review

» Needs work

The '%%d' is not a typo. It is there because '%d' will get processed by db_query() and will mess up any arguments to the query.

Log in or register to post comments

Comment #4

jcmarco CreditAttribution: jcmarco commented 28 March 2010 at 17:05

Category:	bug	» feature
Status:	Needs work	» Needs review

File	Size
views_date_sql_format_ext_2.patch	1.3 KB

Ok, I found it while testing with more strings.
I even found that %b requires to be escaped as well.

Changed for a feature request to support more strings.

I am working in a patch for views_handler_field_date.inc to support
date formats configured with Data API, and option to support native
date_format in queries to solve problems grouping information.

Log in or register to post comments

Comment #5

jcmarco CreditAttribution: jcmarco commented 28 March 2010 at 17:06

Title:

views_date_sql_format has a typo with days

» Add more date format string to views_date_sql_format

Log in or register to post comments

Comment #6

merlinofchaos CreditAttribution: merlinofchaos commented 28 March 2010 at 18:16

It would be true for %b, %d, %s, %f -- I see a %s in there too. Odd that %d was covered and %s was not.

Log in or register to post comments

Comment #7

jcmarco CreditAttribution: jcmarco commented 29 March 2010 at 08:36

File	Size
views_date_sql_format_ext_3.patch	1.32 KB

You were absolutely right!

The %s was wrong.

I didn't translate %f as it seems that using microseconds is not usual.
Do you consider a good idea trying to translate all the strings from http://us.php.net/manual/en/function.date.php?