Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Hi,
i use the fieldgroup tabs module and, in my previous theme, when the tab had no content it was hidden.
I noticed that when i use the original "content-field.tpl.php" from the cck module, the tabs are hidden properly.
i tried to change the code from adaptivetheme content-field.tpl.php but couldn't find out what was causing it...
any help?
ps
Great theme!!!
Comment | File | Size | Author |
---|---|---|---|
#6 | adaptivetheme-empty_content_fields-766888-6.patch | 452 bytes | Agileware |
Comments
Comment #1
Jeff Burnz CreditAttribution: Jeff Burnz commentedOK, I'm looking into it, cheers.
Comment #2
Jeff Burnz CreditAttribution: Jeff Burnz commentedOK, so this is really going to surprise you...
The issue caused by the comment in AT's content-field.tpl.php file, on the very last line of code you will see this:
Remove
<!-- /content-field -->
and the problem is fixed.I'll remove the comment also and commit the change to the DEV version.
Comment #3
Jeff Burnz CreditAttribution: Jeff Burnz commentedCommitted.
Comment #4
jimkont CreditAttribution: jimkont commentedWorks fine!
Thanks!
Comment #6
Agileware CreditAttribution: Agileware commentedThis seems to have regressed.
It also causes panels panes to render when empty.
Patch against 6.x-2.x-dev
Comment #7
Jeff Burnz CreditAttribution: Jeff Burnz commentedCommitted to 2x dev, Thanks!
BTW - yes we had a regression, I made a silly mistake with CVS a while ago, my bad.
Comment #8
Jeff Burnz CreditAttribution: Jeff Burnz commented. ignore, something odd going on with comments here...
Comment #9
Jeff Burnz CreditAttribution: Jeff Burnz commented@Agileware - hey just thought I'd mention that if you really want to play with this theme I'd go for the 3x version that's in development, there's an RC1 but that's already out of date and needs a new release. In AT3 we ripped out about 1000 lines of code and massively simplified the advanced theme settings (the classes stuff) - after a year of usage we figured out what we used all the time and decided to just turn them on by default make the classes settings very simple.
Comment #10
Agileware CreditAttribution: Agileware commentedThanks I'll look into that.
Currently I have a site redesign about to go live on a sub-theme of adaptivetheme 2x so it's probably too late for that one.
Would it be a relatively smooth transition to upgrade from 2.x to 3.x or would it potentially cause a lot of headaches?
Comment #11
Jeff Burnz CreditAttribution: Jeff Burnz commentedLots of headaches... don't do it, live with AT2 for the life-cycle, I'm going to maintain it for all the D7 cycle because we have lots of clients sites that use it also.
Comment #12
Agileware CreditAttribution: Agileware commentedI thought as much, thanks.