Hi,
i use the fieldgroup tabs module and, in my previous theme, when the tab had no content it was hidden.

I noticed that when i use the original "content-field.tpl.php" from the cck module, the tabs are hidden properly.

i tried to change the code from adaptivetheme content-field.tpl.php but couldn't find out what was causing it...
any help?

ps
Great theme!!!

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Jeff Burnz’s picture

Assigned: Unassigned » Jeff Burnz

OK, I'm looking into it, cheers.

Jeff Burnz’s picture

OK, so this is really going to surprise you...

The issue caused by the comment in AT's content-field.tpl.php file, on the very last line of code you will see this:

<?php endif; ?> <!-- /content-field -->

Remove <!-- /content-field --> and the problem is fixed.

I'll remove the comment also and commit the change to the DEV version.

Jeff Burnz’s picture

Status: Active » Fixed

Committed.

jimkont’s picture

Works fine!

Thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Agileware’s picture

Title: Empty fieldgroup tabs not hidden » Empty cck fields being rendered as a HTML comment. Affects fieldgroup tabs, panels etc.
Version: 6.x-2.2 » 6.x-2.x-dev
Status: Closed (fixed) » Needs review
FileSize
452 bytes

This seems to have regressed.
It also causes panels panes to render when empty.

Patch against 6.x-2.x-dev

Jeff Burnz’s picture

Status: Needs review » Fixed

Committed to 2x dev, Thanks!

BTW - yes we had a regression, I made a silly mistake with CVS a while ago, my bad.

Jeff Burnz’s picture

. ignore, something odd going on with comments here...

Jeff Burnz’s picture

@Agileware - hey just thought I'd mention that if you really want to play with this theme I'd go for the 3x version that's in development, there's an RC1 but that's already out of date and needs a new release. In AT3 we ripped out about 1000 lines of code and massively simplified the advanced theme settings (the classes stuff) - after a year of usage we figured out what we used all the time and decided to just turn them on by default make the classes settings very simple.

Agileware’s picture

Thanks I'll look into that.

Currently I have a site redesign about to go live on a sub-theme of adaptivetheme 2x so it's probably too late for that one.
Would it be a relatively smooth transition to upgrade from 2.x to 3.x or would it potentially cause a lot of headaches?

Jeff Burnz’s picture

Lots of headaches... don't do it, live with AT2 for the life-cycle, I'm going to maintain it for all the D7 cycle because we have lots of clients sites that use it also.

Agileware’s picture

I thought as much, thanks.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.