Offshoot of #560482: Consider merging with menu_breadcrumb.

Currently Menutrails sets a breadcrumb for Views page displays based on the page's menu item (if any).

As reported in #702350: Page title is always included in the breadcrumb for node not processed by menutrails, this functionality is broken because the breadcrumb generated by menutrails_get_breadcrumb() includes the current page (since it's designed to find parents of a node).

In any case, menu-based breadcrumb setting is outside the main focus of menutrails and probably better left to the Menu breadcrumb module.

CommentFileSizeAuthor
#1 767558-1-menutrails-remove-views-breadcrumb.patch874 bytesnedjo
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

nedjo’s picture

nedjo
he/him/his
Primary language English
CreditAttribution: nedjo commented
Status: Active » Needs review
FileSize
767558-1-menutrails-remove-views-breadcrumb.patch874 bytes

Patch attached.

nedjo’s picture

nedjo
he/him/his
Primary language English
CreditAttribution: nedjo commented

Views page display breadcrumb setting is currently broken in menu_breadcrumb, see #275622: Doesn't work for Views pages, but that doesn't really alter the basic point that that is the better home for this breadcrumb setting.

sun’s picture

sun
Primary language German
Location Karlsruhe
CreditAttribution: sun commented

This code and feature was introduced in #340725: Views integration. If we want or need to revert it for whatever reason, then we probably should discuss and do that in the original issue.