When you remove the WYSIWYG library for an active profile, the text declaring which WYSIWYG the profile uses is replaced by a smooth blank space. Some indicator of "Missing Plugin" would be helpful.

Comments

Version:6.x-2.1» 7.x-2.x-dev
Status:Active» Needs review
StatusFileSize
new990 bytes
new947 bytes
new937 bytes

Ah, good point.
I changed it to read WARNING: %editor library is missing! where %editor is the title of the assigned editor.
This requires separate patches for D5/6/7 due to changes in FAPI, but they're almost the same.

+++ wysiwyg.admin.inc 15 Apr 2010 20:27:56 -0000
@@ -434,8 +434,9 @@ function wysiwyg_profile_overview($form,
-        '#markup' => $options[$profiles[$id]->editor],
+      '#markup' => isset($options[$editor_name]) ? $options[$editor_name] : t('WARNING: %editor library is missing!', array('%editor' => $editors[$editor_name]['title'])),

The "WARNING:" is normally done by applying the "warning" CSS class to a table row.

Overall, we should test-drive this patch a bit in HEAD, before attempting to backport it.

I was under the impression that the installation instructions fieldset should get automatically expanded in case a library is missing?

Powered by Dreditor.

Yeah, it should, but I guess people don't notice that. This change would perhaps also make it a bit more obvious which text formats are affected?

> I was under the impression that the installation instructions fieldset should get automatically expanded in case a library is missing?

Didn't seem to do that for me:

Wysiwyg profiles broken.png

An expanding fieldset is useful to help you get the library, but it's a poor warning mechanism when you are *sure* you already downloaded and got a library working for the site in the past.

Status:Needs review» Needs work
StatusFileSize
new1.78 KB

Not sure I like the rendering logic, but I didn't find a cleaner solution.

The fieldset won't expand when an editor is not installed at all, as it doesn't check if a profile uses it and thus doesn't know it should be installed.

UPDATE: This also fixes

Notice: Undefined index: ckeditor in wysiwyg_profile_overview() (line 458 of ....../wysiwyg.admin.inc).

Status:Needs work» Needs review

Stupid status field, keeps doing the opposite of what I want...

Status:Needs review» Reviewed & tested by the community
StatusFileSize
new1.74 KB

@TwoD: Git is complaining about the line endings in your patch.

I was under the impression that the installation instructions fieldset should get automatically expanded in case a library is missing?

This is true when you had only one editor. When you have multiple installed the image from #4 is what you get.

The patch from #6 fixes this nicely. I re-rolled it just for the line endings.

Status:Reviewed & tested by the community» Needs review
StatusFileSize
new2.53 KB

Changed a few things to better indicate which library is missing and to not rely on translated string comparison in the theme function.
Is this too much?

StatusFileSize
new2.53 KB

Argh! Stupid Windows hiding the real file extension!
Wouldn't surprise me if git complains about file endings being wrong this time too, despite that I've never actually opened the file in Windows...

Status:Needs review» Reviewed & tested by the community

#10 still applies cleanly to 7.x-2.x HEAD and fixes the problems described

Status:Reviewed & tested by the community» Fixed

Slightly ;) shortened the warning message...

Thanks for reporting, reviewing, and testing! Committed to 7.x-2.x.

A new development snapshot will be available within the next 12 hours. This improvement will be available in the next official release.

Status:Fixed» Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Issue summary:View changes

Backported this to 6.x.