In #344046: Add Cleartype options in the settings page. a patch was committed that must not have been tested. The patch saves the string literals "true" or "false" to the database and loads these in to JQuery settings. Since "false" is evaluated to true in Javascript these settings are ignored and animations look horrible in IE6 with Cleartype enabled.

Attached is a patch to resolve this.

Comments

StatusFileSize
new5.46 KB

Attachment is here

Status:Patch (to be ported)» Needs work

The patch makes sense. We can't change the values so we'll have to evaluate the options. but I'll work on the patch.

We can't change the values

What if you supplied a hook_update_n() which update all view displays with this type changed "false" to 0 and "true" to 1. This would keep the values consistent with the other settings.

Status:Needs work» Fixed
StatusFileSize
new1.97 KB

No hook_update for views settings unfortunately. To make the change I would have to make an exception in init() for views. It's possible to do, but then I would have to make an exception for whatever other views_slideshow module would need it. I think I will do a big change in a next major release. Here is the patch I committed.

You can define your own update function that is called when update.php is run. You could just do a simply SQL query to get all views where views_rotator appears in the display_options. Load up the actual view and update the display settings. See http://api.drupal.org/api/function/hook_update_N

And according to Drupal's Javascript coding standards "Eval is evil" and you are probably better off just checking if settings.ie.cleartypenobg == "true"
http://drupal.org/node/172169#eval

Well you can't do hook_update_N for any views style plugin variables. You have to do an init() this is straight from merlinofchaos himself. As far as eval. We use it in one place already, but that is a requirement. It is not a requirement here so I'll use the checking for if it is "true".

Thanks

Committed the change to remove eval. Now using comparison. Thanks

Status:Fixed» Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.