Hi there,

To properly develop in Drupal, you should turn on the E_NOTICE on your development machine (See #761780: Plenty of E_ALL notices in modules developed on installation with Drupal tarball.)

I got a notice today and am attaching a patch.

The definition and use of $js_id in the array_merge() looks okay. But I'm wondering... Because later you re-use $js_id many times when it may be NULL. Isn't that part possibly invalid?

<?php
         
//loop through all enabled filters
         
foreach ($enabled as $id => $filter) {
           
//but use only that one selected in FCKeditor profile
           
if (in_array($id, array_keys($_fckeditor_configuration[$textarea_id]['filters'])) && $_fckeditor_configuration[$textarea_id]['filters'][$id]) {
              if (!isset(
$fckeditor_filters[$js_id])) {
               
$fckeditor_filters[$js_id] = array();
              }
             
$fckeditor_filters[$js_id][] = $id ."/". $format;
            }
          }
?>

Thank you.
Alexis Wilke

Files: 
CommentFileSizeAuthor
fckeditor-e_notice-6.x.patch593 bytesAlexisWilke

Comments

Status:Needs review» Fixed

Fixed in CVS. The loop should be skipped when the array element can't be found.

Status:Fixed» Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.