Add support to record and display external dependencies included in release packages [#779996]

Comment #1

hunmonk CreditAttribution: hunmonk commented 24 April 2010 at 17:35

i guess the trickiest part i see from a technical standpoint is getting this info from drush_make to project_package for these external items.

for the local package items, all we need is the release nid of the local item, so in the drush_make_d_o plugin i just dump a list of nids to a temp file, then read that list back in later in the packaging script.

if we kept this basic approach, we'd certainly need to provide more structure to the data in the temp file -- maybe the old standby .info file format?

Log in or register to post comments

Comment #2

philbar CreditAttribution: philbar commented 25 April 2010 at 04:12

Status:

Active

» Postponed

This should probably be postponed until the following issue is closed:
#684788: Verify Library URLs against a White-list for drupal-org.make

Once Drush's drupal-org.make can support external libraries, then we can worry about fetching and displaying that data in the release node.

Log in or register to post comments

Comment #3

hunmonk CreditAttribution: hunmonk commented 25 April 2010 at 06:46

Status:

Postponed

» Active

they will be worked on concurrently, and deployed together. anything we're adding to d.o packages is going to have display support.

Log in or register to post comments

Comment #4

mikey_p CreditAttribution: mikey_p commented 30 August 2011 at 21:23

Issue tags:

+drupal.org distribution blockers

Tagging

Log in or register to post comments

Comment #5

boombatower CreditAttribution: boombatower commented 31 August 2011 at 00:21

sub

Log in or register to post comments

Comment #6

dww

we/he/they

CreditAttribution: dww commented 9 December 2011 at 19:03

An initial commit for the plumbing here is now in:
http://drupal.org/commitlog/commit/122/ffe06337092ec49fc7450eff4d26ab772...

In terms of getting this data back from drush make... there's already a .info file that describes all the external libraries included in the package -- the drupal-org.make file itself! So long as drush make returns success, we know anything listed in there was included. So, instead of telling drush make to vomit its own input back out as output, let's just parse the .make file in the distro packaging plugin and populate these project_package tables directly via the new project_package_record_remote_item() API we've added here. It should hopefully be trivial to iterate over $info['libraries'] and do the right thing. In fact, the distro packaging plugin is *already* parsing the .make file to do some validation on the 'core' attribute.

Log in or register to post comments

Comment #7

mikey_p CreditAttribution: mikey_p commented 10 December 2011 at 02:03

So we have storage down, the code for getting this data into the DB is at #1366482: Fix distribution packaging plugin to record patches and libraries included in distributions at the moment. I don't think it makes sense to split it out, since it's pretty intertwined with the code to record patches as well as libraries.

Initial views support for displaying this data is included over at #779998: Add support to record patches applied to release packages. Once again I didn't split out patch vs. remote items but I certainly could do that if necessary.