Attached patch removes a significant number of is_array calls.

Profile on one of our sites shows these reductions in is_array calls:
unpack_options@3: -43.8%
unpack_options@2: -29.9%
unpack_options@1: -26.3%

Page Render Incl Wall time improved 3.0% with patch.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

dawehner’s picture

Status: Active » Needs work

Update status


+        $this->unpack_options($storage[$key], $value, isset($definition[$key]['contains']) ? $definition[$key]['contains'] : array(), false);

should be FALSE

lewisvance’s picture

Status: Needs work » Active
FileSize
1.09 KB
dawehner’s picture

Status: Active » Needs review

Thanks. This looks fine.

Kars-T’s picture

Status: Needs review » Reviewed & tested by the community

Around 5% of my page build time gets eaten by unpack_options().

This patch gives me only 10% speed gain as I can see through xdebug profiling but better than nothing. Otherwise I'd say its a nice little patch.

Setting this RTBC.

omerida’s picture

I applied the patch w/o unintended side effects. +1 for Views performance improvements!

dawehner’s picture

FileSize
1.04 KB

Here is a rerole for views3

merlinofchaos’s picture

Status: Reviewed & tested by the community » Fixed

Committed to all branches.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.