Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Attached patch removes a significant number of is_array calls.
Profile on one of our sites shows these reductions in is_array calls:
unpack_options@3: -43.8%
unpack_options@2: -29.9%
unpack_options@1: -26.3%
Page Render Incl Wall time improved 3.0% with patch.
Comment | File | Size | Author |
---|---|---|---|
#6 | is_array_1-v3.patch | 1.04 KB | dawehner |
#2 | is_array.patch | 1.09 KB | lewisvance |
profile.png | 59.21 KB | lewisvance | |
is_array.patch | 1.09 KB | lewisvance | |
Comments
Comment #1
dawehnerUpdate status
should be FALSE
Comment #2
lewisvance CreditAttribution: lewisvance commentedComment #3
dawehnerThanks. This looks fine.
Comment #4
Kars-T CreditAttribution: Kars-T commentedAround 5% of my page build time gets eaten by unpack_options().
This patch gives me only 10% speed gain as I can see through xdebug profiling but better than nothing. Otherwise I'd say its a nice little patch.
Setting this RTBC.
Comment #5
omerida CreditAttribution: omerida commentedI applied the patch w/o unintended side effects. +1 for Views performance improvements!
Comment #6
dawehnerHere is a rerole for views3
Comment #7
merlinofchaos CreditAttribution: merlinofchaos commentedCommitted to all branches.