I have a design that requires rounded edges on the first and last pager items.

I was a little surprised that the classes for pager items were hard-coded into the Javascript. I was even more surprised to find out that, although the classes for 'odd' and 'even' were there, the classes for 'first' and 'last' were not.

I have attached a simple patch that adds these classes.

Comments

StatusFileSize
new38.21 KB

good idea on the first and last classes. The reason they are hard coded into SingleFrame was pagers were an after thought and I was using the pager support in jQuery cycle. If you want stronger control of your pagers I would look at thumbnailhover.

Status:Needs review» Fixed

This has been committed.

Status:Fixed» Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Version:6.x-2.0» 7.x-3.x-dev
Status:Closed (fixed)» Needs review
StatusFileSize
new2.24 KB

I'm not seeing 'first' and 'last' classes on pager items in 7.x-3.x. This patch adds them.
It also breaks up a couple long lines of code (into <80 char lines.)

Status:Needs review» Needs work

the patch #5 works well,

but I'd prefer to insert "views-row-first" and "views-row-last" classes instead of "first" and "last"

(for odd and even is used "views-row-odd" and "views-row-even")

Assigned:RoloDMonkey» Unassigned

Status:Needs work» Needs review
StatusFileSize
new2.26 KB

Point taken. Looks like that's how Views usually does it anyway.
Thanks for reviewing!

Status:Needs review» Reviewed & tested by the community

Thanks for the new patch!

New patch for 7.x-dev version

Status:Reviewed & tested by the community» Fixed

Thanks a lot to RoloDMonkey, redndahead, jeffschuler, robertom, igor.ro and everyone else for the great work on the patches, testing, reviews and reporting.

It's more time this got committed and I went ahead and had this rolled at:
6.x-2.x: 5bf14e2.
6.x-3.x: fe544f9.
7.x-3.x: bda8444.
Marking this as fixed.

Please let me know if you would have any other questions, comments, issues or concerns on any of these changes, I would be glad to provide more information.
Thanks again to everyne for the help and great work on this issue.
Cheers!

Status:Fixed» Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

hello

I've just installed the 7.x-3.x-dev and the problem is still there, no first and last classes

is there any patch for this version ?

thank you

Sorry, I can't reproduce this issues. Could you try to use the latest 7.x-3.x-dev and double-check the HTML class?

it's the last version : 7.x-3.0+24-dev

you can see my test here :
http://www.dethier.be/en/projets/welkenraedt-funeral-centre
no first & last for the rows/slides

StatusFileSize
new190.47 KB

You can use Firebug or Chrome Developer Tools, it is easy to search called "views-row-first" and "views-row-last" of classes (attached).

yes, it has just changed with last updates, all seems ok now

thank you