When this module is enabled, the following warning is thrown whenever a page is loaded:

PHP Warning: Call-time pass-by-reference has been deprecated in /mysite/modules/signup_status/modules/signup_status_limit/signup_status_limit.settings.inc on line 24

Similar warnings has been reported in other Drupal modules and it seems the consensus is to fix the issue by removing pass-by-reference calls (in this case, changing "function signup_status_limit_alter_signup_node_settings_form(&$form)" to "function signup_status_limit_alter_signup_node_settings_form($form)").

I want to ascertain that this is safe to do in this module before I go ahead. Is it?

CommentFileSizeAuthor
#3 784536_pass_by_reference_on_receiver.patch917 bytesgreggles
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

froboy’s picture

froboy
he/him
Primary language English
Location Chicago, IL
CreditAttribution: froboy commented

I did this and haven't seen any problems with it through some basic testing.

franksweb’s picture

franksweb CreditAttribution: franksweb commented

Solution: http://drupal.org/node/486562

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
CreditAttribution: greggles commented
Priority: Minor » Normal
Status: Active » Needs review
FileSize
784536_pass_by_reference_on_receiver.patch917 bytes

Attached patch should fix this. It's just a warning, not a problem, but we should eliminate as many of these as we can.

Als’s picture

Als
Location Milano, Italia
CreditAttribution: Als commented

Tested patch #3 in Drupal 6.17 + Signup Status 6.x-1.x-dev (11 Jul, latest one): no more warnings.