Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
For various reasons it would be fine, if there would be a update and override button.
Comment | File | Size | Author |
---|---|---|---|
#6 | 787184-views-update_override_button.patch | 3.56 KB | merlinofchaos |
#1 | 787184-views-update_override_button.patch | 1.33 KB | dawehner |
Comments
Comment #1
dawehnerHere is a working version.
Comment #2
Bilmar CreditAttribution: Bilmar commentedHi dereine,
I did some testing with the patch and below are my results:
When the Fields section is set to default display
Buttons available are 'Update default display' 'Override and Update' 'Override' and 'Cancel'
- Clicking Update default display closes the Configure fields, keeps section as Use default
- Clicking Override and Update works as expected => sets section to override and updates in one go
http://www.screencast.com/users/trupal218/folders/Jing/media/393026b8-6e...
- Clicking Override makes the 'Update' and 'Cancel' buttons show
-- clicking 'Update' or 'Cancel' here both still overrides the section (is the cancel button suppose to cancel the overriding of the section? but this seems to be the flow without the patch as well)** http://www.screencast.com/users/trupal218/folders/Jing/media/c657387d-1c...
- Clicking Cancel closes the Configure fields, keeps section as Use default
When the Fields section is set to override
Buttons available are 'Update' 'Cancel' and 'Use Default'
- Clicking Update doesn't change anything => closes the Configure fields, keeps section as override
- Clicking Cancel doesn't change anything => closes the Configure fields, keeps section as override
- Clicking Use Default makes 'Update default display', 'Override and Update', 'Cancel' buttons show
-- clicking 'Cancel' still changes the section to Use default (again, i'm not too clear about this flow)**
-- clicking 'Update default display' changes the section to Use default (when the section has more fields than the default display, the Fields section is set to show fields only in default display). http://www.screencast.com/users/trupal218/folders/Jing/media/7ea60299-54...
-- clicking 'Override and Update' loses any changes to the overridden Field section that was saved or not saved, returned Field section to fields in default display but keeps the section as override (not sure if this is intended behavior) http://www.screencast.com/users/trupal218/folders/Jing/media/29cdd090-a0...
Please let me know if I'm misunderstanding how the Cancel button should be working (marked above with **).
If it's a bug I can open a new issue in the queue.
Thanks!
Comment #3
merlinofchaos CreditAttribution: merlinofchaos commentedThis is true without the patch too. That's a behavior that has never been handled properly in Views (it requires longer term cached tracking that hasn't been implemented)
This one seems wrong.
Comment #4
dawehnerWhen the Fields section is set to default display
This is exactly how it should be.
Yeah this is not part of this patch, sorry :)
When the Fields section is set to override
All default behavior.
Once you clicked "use default" the changes are made against the default.
This is exactly how views worked before. I just added the button, everything else wasn't changed :)
If you click "use default" the settings are deleted and the settings from the default display are used. From my perspective it's exactly how the behaviour should be.
@earl
Watching the video helps a lot here.
@trupal218
It's crazy how awesome your tests are. It's indescribable
Comment #5
Bilmar CreditAttribution: Bilmar commentedAlways a pleasure to help with testing! =)
Comment #6
merlinofchaos CreditAttribution: merlinofchaos commentedOk, I changed the wording on the button and committed this to both D6 branches.
Also, the button was not properly marking the right section as updated with the patch; since it thought it was updating the default display, it marked *that* as changed, not what was actually changed. I added submit chaining to make this happen properly, and moved the old submit out of the validate function, which is an odd place for it to be.
Actual patch is attached. Needs porting to D7.
Comment #7
dawehnerCommited, and ported
Perhaps i should find a message which i can copy and paste for every comment. :)
Comment #9
iamjon CreditAttribution: iamjon commentedMarked #737764: lock default display as a duplicate