basic code review before releasing a stable version (along with several other open issues).

These are main priority areas to worry about:

  • Formatting and Spacing conventions (ala drupal)
  • Doxygen comments
  • Naming conventions (esp. for css classes and functions)
  • What drupal standards are there for JS?

Right now the module is so terse I think we could run through these together with little problem, but we can break these out as separate issues for anything that can't be done in a first pass.

See:

http://drupal.org/coding-standards
http://drupal.org/projects/coder

Comments

erykmynn’s picture

erykmynn CreditAttribution: erykmynn commented

oops...

http://drupal.org/project/coder

erykmynn’s picture

erykmynn CreditAttribution: erykmynn commented
Assigned: Unassigned » erykmynn
Anonymous’s picture

Anonymous (not verified) CreditAttribution: Anonymous commented
Status: Active » Needs review

I ran the module through Coder and resolved all the issues. There were a bunch of little formatting fixes, but primarily I removed t()'s from the menu titles and descriptions. Committed to HEAD in #403990