Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Just infront i like your theme. Its simple and the user (normal one) gets what he can interact with. I would have a suggestions:
1. Seperate the sldies-bard visually better from the image itself. It is not only confusing for newcomers, "that the can directly selec there" but also gets the eye distracted from actually looking at the other pictures
My solutions for that would be, greying out the slidebar below until the mouse hovers any picture below (entering the slide area). Maybe also add a bit more space - but that might then not even needed. Just a grey overlay.
What do you think?
| Comment | File | Size | Author |
|---|---|---|---|
| #10 | galleryformatter-800240-1.patch | 1.25 KB | Manuel Garcia |
| #10 | galleryformatter-800240-1.png | 323.19 KB | Manuel Garcia |
| #1 | galleryformatter-800240.patch | 1.17 KB | Manuel Garcia |
Comments
Comment #1
Manuel Garcia CreditAttribution: Manuel Garcia commentedTrue, we could work a bit on this area.
Not sure I'm understanding what you mean by "grey overlay", I'm thinking we could set the opacity to let's say 0.6 on all thumbnails, then set the active and hover thumbnails to opacity: 1.
Seems like it would make it clearer to the user in my opinion.
Please see the attached patch to check out what I mean.
Comment #2
Manuel Garcia CreditAttribution: Manuel Garcia commentedFYI, I have committed the patch above, welcome to discuss this further.
Setting it to fixed, but feel welcome to reactivate to disucss further. An image describing further enhancements would realy help speed up the conversation.
Comment #3
EugenMayer CreditAttribution: EugenMayer commentedThanks for the fast answer. I will try that one out and come back with feedback. Sounds great already
Comment #4
EugenMayer CreditAttribution: EugenMayer commentedWell tried the patch. I think the opacitiy is nearly not changin anything. I would actually use a grey-overlay and give that and overlay. And that overlay is removed on mouse over / being active.
What do you think about that?
Comment #5
Manuel Garcia CreditAttribution: Manuel Garcia commentedI'm not understanding what you mean EugenMayer, could you make an image to explain the behaviour you describe?
Comment #6
EugenMayer CreditAttribution: EugenMayer commentedSure :
http://www.ubuntu-pics.de/bild/64581/screenshot_203_dS5JBj.png
Guess this makes it clear :)
Comment #7
Manuel Garcia CreditAttribution: Manuel Garcia commentedI think that's exaclty what opacity does... at least on pictures it looks fine, look at my example: http://www.ubuntu-pics.de/bild/64587/galleryformatter_hover_not_eDsL69.png
Comment #8
EugenMayer CreditAttribution: EugenMayer commentedWell actually now you just fade out with opacity. That only works good for highcontrast / dark pictures.
My approach is to overlay with a div which has a grey background.
Comment #9
Manuel Garcia CreditAttribution: Manuel Garcia commentedI'll see what I can do, I do see your point, perhaps on other backgrounds the opacity alone would not work that well. Stay tuned!
Comment #10
Manuel Garcia CreditAttribution: Manuel Garcia commentedOK, here is the problem:
We cannot use the background gray on the
<a>tags because they need to be using padding for the bg images, and cant use margin for this reason.This means we cannot give a bg color to the images themselves so they show like a "gray overlay".
I've tested another approach, which is giving a gray bg to that whole section in the gallery, the thumbnails area. See attached screenshot.
I was really hoping to not do this, and leave this to the theme itself, so that the default theme would be usable in most situations. So I really doubt this patch will go in. I find it cleaner if the bg of the thumbnails is the same as the rest of the node itself.
I have also added a slight border for the thumbnails, maybe that helps a bit, but I dont like setting a fixedd color to the background of that whole section.
The only way to do this is to insert another div wrapping the image itself, just for this porpuse, which I wont do because its already too much markup, and I dont think we should do this in jQuery, because who knows how many images users will put in here, I want to keep the JS as fast as possible.
So for now, I feel we will stick with just opacity changes, perhaps add the border around the images, but I'll leave the contrast problems to the themers themselves. I want them to be free to use this gallery style, and not impose bg colors on them.
I'm opened to suggestions, but please do understand what approach I am trying to have with the greenarrows style.
Comment #11
Manuel Garcia CreditAttribution: Manuel Garcia as a volunteer and at Appnovation for Pfizer, Inc. commented6.x-1.x branch no longer supported