Maximizing portlets

Bug described by mikesteff
Occasionally, the block doesn't expand across the regions, then disappears a few seconds later..

I have tested this on ...

• MacOSX Chrome/FF/Safari
• WinXP Chrome/FF
• Ubuntu 10.04 FF

... without being able to reproduce the bug.
Anyone please register at http://www.dashboard.helgemorgenstern.de and try to reproduce this bug (simply try to maximize/minimize some widgets on the frontpage dashboard). Thanks!

aaaah ... yeah ...
I got it :)
try to drag/move your widget by clicking on the maximize button.
seems like maximizing interferes with drag-action

all right I fixed both:
- no more bug when dragging the widget through maximize icon
- close icon is hidden when maximized

new javascript code:

    // Add maximize link to every portlet
    $boxes.find('.portlet-header .portlet-close').after('<span class="portlet-icon portlet-maximize"></span>')
    // Attach click event to maximize icon
    $boxes.find('.portlet-header .portlet-maximize').click(function() {
      // references to active portlet and its homebox
      var portlet = $(this).parents(".homebox-portlet");
      var homebox = $(this).parents("#homebox");
      
      // only fire this action if this widget isnt being dragged
      // see bug description at http://drupal.org/node/800468#comment-2982830
      if (!$(portlet).hasClass("ui-sortable-helper")) {
        // check if we're maximizing or minimizing the portlet
        if ($(portlet).hasClass("portlet-maximized")) {
        // minimizing portlet
          
          // move this portlet to its original place (remembered with placeholder)
          $(portlet).insertBefore($(homebox).find(".homebox-maximized-placeholder"))
            .toggleClass("portlet-maximized");
            
          // remove placeholder
          $(homebox).find(".homebox-maximized-placeholder").remove();
          
          // show columns again
          $(homebox).find(".homebox-column").show();
          
          // show close icon again
          $(portlet).find(".portlet-close").show();
          
        } else {
        // maximizing portlet
          
          // add a place for maximized content (if not available, yet)
          if ($(homebox).find(".homebox-maximized").length == 0) {          
            $(homebox).find(".homebox-column:first").before("<div class=\"homebox-maximized\"></div>");
          }
          
          // add the portlet to maximized content place and create a placeholder (for minimizing back to its place)
          $(portlet)
            .before("<div class=\"homebox-maximized-placeholder\"></div>")
            .appendTo($(this).parents("#homebox").find(".homebox-maximized"))
            .toggleClass("portlet-maximized");
            
          // hide columns - only show maximized content place (including maximized widget)
          $(homebox).find(".homebox-column").hide();

          // hide close icon (you wont be able to return if you close the widget)
          $(portlet).find(".portlet-close").hide();
          
        }      
      }
    });

Well I actually just thought of maximizing widgets as a temporary way to get your widget more space. So I haven't built any saving stuff for it yet. But I guess it should be rather easy to do so. Probably it's best to wait for your code including the 'save' button and add saving of maximized widgets on top of that.

So we'll probably get a general admin settings page for homebox in the future I guess. We could make this an optional setting then as in my opinion that's a matter of taste and some people probably would like to have only the maximized widget available. I'll start a feature collection for maximized widgets in a second comment.

A quick solution would be leaving out these lines:

          // show columns again
          $(homebox).find(".homebox-column").show();

and

          // hide columns - only show maximized content place (including maximized widget)
          $(homebox).find(".homebox-column").hide();

ToDo / Features

This is a list of request features for Maximized Widgets. I'll update this list in case any of new feature requests or solved features.

• Saving the state of maximized widgets
• Optionally showing all other widgets below maximized widget

mikesteff is right! Maximized widgets should take the whole screen by default. That's what users expect.

#17: Yeah I noticed this buggy behaviour on my sandbox, too. However I thought it's being caused only by those experimental external widgets I use there.