I notice in includes/destinations.ftp.inc that you've copied the drupal_ftp module code here. I'm guessing the reasoning behind this, is because at the time that backup_migrate was built, drupal_ftp didn't have a Drupal 6 version available? As of almost a year ago, a Drupal 6 version is available though.

So currently, if a site tries to install backup_migrate on a site with drupal_ftp installed, there are function name conflicts. Note: the errors only occur during module install or when running backup_migrate.

How do we go forward? I'm thinking one of the following:
* rename the drupal_ftp functions used in backup_migrate to be something different, or
* rename the drupal_ftp project (actually suggested this here #714798: renaming this project to something more appropriate), or
* adjust drupal_ftp to suit backup_migrate's use of the code, and make drupal_ftp a dependency of backup_migrate.

I'm one of the co-contributors to drupal_ftp and don't mind what happens, as long as this is resolved so the both can co-exist in the drupal world.

Thanks.

Comments

ronan’s picture

ronan CreditAttribution: ronan commented

Hi,

Yeah, I did indeed copy the code. I thought at the time that the drupal ftp module looked a little abandoned. It's good to see I was wrong about that. My original goal was to have have my module depend on the drupal_ftp module for FTP backups, so if the third option you mention sounds good to you, then I'd be happy to go that way.

It'll probably take a little time to get releases coordinated and whatnot so I should probably implement the first suggestion in the mean time (or at least conditionally declare the functions).

Let me know if you are interested working together to make the dependency option work.

alexkb’s picture

alexkb CreditAttribution: alexkb commented

Hey ronan, thanks for the comment back, and apologies for not getting back to you earlier.

I think that both the 2nd and 3rd options should take place. I'll make #2 so, and then comment back here when its done.

ronan’s picture

ronan CreditAttribution: ronan commented
Status: Active » Postponed (maintainer needs more info)

Sounds good. Let me know when you've gotten the rename done and I'll get back to figuring out how to move the functionality back to your module.

kim.pepper’s picture

kim.pepper
Primary language English
Location 🏄‍♂️🇦🇺Sydney, Australia
CreditAttribution: kim.pepper commented

Is there any way to switch off the backup_migrate version of drupal_ftp? We have a module that depends on it, and we don't use the ftp feature of the backup_migrate module.

Kim

alexkb’s picture

alexkb CreditAttribution: alexkb commented

Hey Ronan, I started doing this, and then after searching through a few things, found the Storage API module which provides an ftp api already. While it'd be great to have drupal_ftp as a dependency of such a great module (backup_migrate), Storage API also covers S3 and other CDN's for storage too - so I think its a better fit.

Have you considered doing something like this before, if so, why not? if not, I'd be interested in helping you if you like.

ronan’s picture

ronan CreditAttribution: ronan commented
Issue summary: View changes
Status: Postponed (maintainer needs more info) » Closed (works as designed)

I'm not sure this is an issue any more, but reopen if you still want to talk about combining forces on this.